From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122782 invoked by alias); 6 Feb 2020 14:22:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122760 invoked by uid 89); 6 Feb 2020 14:22:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2020 14:22:22 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 391B8201F1; Thu, 6 Feb 2020 09:22:21 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id B4060201F1; Thu, 6 Feb 2020 09:22:19 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B14FD2816C; Thu, 6 Feb 2020 09:22:15 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 06 Feb 2020 14:22:00 -0000 From: "Simon Marchi (Code Review)" To: Mihails Strasuns , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] jit: enhance test suite X-Gerrit-Change-Id: I5f9d56e8eaaa7cf88881eda6a92a72962dd3f066 X-Gerrit-Change-Number: 757 X-Gerrit-ChangeURL: X-Gerrit-Commit: 787af04c078a23c9144f48718a7dd4a05c8d3f00 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 6 Feb 2020 09:22:15 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200206142215.B14FD2816C@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-02/txt/msg00132.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/757 ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > What about this: the -Ttext-segment=org linker option allows us to define the base of the text segment of the generated binary. We could use that to generate a binary whose text is specifically made to live at a certain address (say, 0x800000), and the generated DWARF information will automatically be generated based on that address. > > I like this a lot and from a quick experiment it does seem to work as desired. > > One clarification about existing jit.exp tests though - they currently try to load the same library multiple times in a loop and register it as different jit instances. If dynamic binary patching is replaced with -Ttext-segment approach, it won't work anymore. I am currently planning to change it to compile separate binaries each with own fixed base address. Is that OK? Yeah, I think it would make sense. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I5f9d56e8eaaa7cf88881eda6a92a72962dd3f066 Gerrit-Change-Number: 757 Gerrit-PatchSet: 1 Gerrit-Owner: Mihails Strasuns Gerrit-Reviewer: Mihails Strasuns Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Thu, 06 Feb 2020 14:22:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment