[review] infrun: mark an exited thread non-executing when attempting to stop

Tankut Baris Aktemur (Code Review)
2019-11-04T08:36:02Z

Tankut Baris Aktemur has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133
......................................................................

Patch Set 1:

> Patch Set 1: Code-Review+1
>
> This looks like an old oversight when handling the case of exited threads when we're attempting to stop all of them. Looking at older code, we used to have a message saying a thread had exited while we were stopping it, but it was removed by a cleanup.
>
> The change looks good for me.

Thank you. I noticed that the patch has a problem. It leaves the exited inferior in an alive state with no threads. It becomes not possible to re-run the program. I will send a revision, together with updated tests.

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408
Gerrit-Change-Number: 133
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Comment-Date: Mon, 04 Nov 2019 08:35:58 +0000