Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review] [gdb/testsuite] Add note to 'Race detection' entry in README
Date: Tue, 04 Feb 2020 10:10:00 -0000	[thread overview]
Message-ID: <20200204101027.39F0C2816C@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1580725026000.I12ef2f0ec35abc5a0221585bf30e5f4f0616aa7c@gnutoolchain-gerrit.osci.io>

Tom de Vries has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/762
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Out of curiosity, do you have an example of this?  Surely, you must have experienced a concrete case of this happening :)

I ran into this while working on https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133 , where I would try to match:
...
[Inferior 1 exited ... ]^M
(gdb) [Inferior 2 exited ... ]^M
...

An easier way to reproduce this is:
...
$ cat gdb/testsuite/gdb.base/check-read1.c
#include <stdio.h>

int
main (void)
{
  printf ("hello\n");
  return 0;
}
...
and:
...
$ cat gdb/testsuite/gdb.base/check-read1.exp
standard_testfile

if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
    return -1
}

if ![runto_main] then {
    fail "can't run to main"
    return 0
}

gdb_test "continue &"
...

Where with make check we have:
...
Running src/gdb/testsuite/gdb.base/check-read1.exp ...
FAIL: gdb.base/check-read1.exp: continue & (timeout)

                === gdb Summary ===

# of unexpected failures        1
...
but with make check-read1 we have:
...
Running src/gdb/testsuite/gdb.base/check-read1.exp ...

                === gdb Summary ===

# of expected passes            1
...


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I12ef2f0ec35abc5a0221585bf30e5f4f0616aa7c
Gerrit-Change-Number: 762
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 04 Feb 2020 10:10:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


  parent reply	other threads:[~2020-02-04 10:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 10:17 Tom de Vries (Code Review)
2020-02-04  5:36 ` Simon Marchi (Code Review)
2020-02-04 10:10 ` Tom de Vries (Code Review) [this message]
2020-02-04 14:25 ` Simon Marchi (Code Review)
2020-02-04 16:37 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2020-02-04 16:37 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204101027.39F0C2816C@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=gdb-patches@sourceware.org \
    --cc=gnutoolchain-gerrit@osci.io \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox