From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113412 invoked by alias); 3 Feb 2020 16:02:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113399 invoked by uid 89); 3 Feb 2020 16:02:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Feb 2020 16:02:17 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8D8712058E; Mon, 3 Feb 2020 11:02:15 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 44D0C202E5; Mon, 3 Feb 2020 11:02:12 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 296372816C; Mon, 3 Feb 2020 11:02:12 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Mon, 03 Feb 2020 16:02:00 -0000 From: "Tankut Baris Aktemur (Code Review)" To: gdb-patches@sourceware.org Cc: Tom de Vries , Pedro Alves , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] infrun: handle already-exited threads when attempting to stop X-Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 X-Gerrit-Change-Number: 133 X-Gerrit-ChangeURL: X-Gerrit-Commit: a32b3dcee11cd3a9f40c5f07757a514074b9051f In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 3 Feb 2020 11:02:11 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200203160212.296372816C@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-02/txt/msg00047.txt.bz2 Tankut Baris Aktemur has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133 ...................................................................... Patch Set 2: > > > > > > FTR, I build patchset 2 and tested the example from PR25478, and hit an assert: > > > ... > > > > I was not able to repeat the problematic scenario with the current master. > > Do you mean with 'problematic scenario' PR25478 as such, or the assert? Sorry for the vagueness. I was referring to the test scenario I gave in the patch description. Like, scenarios that can be used for testing as in https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/134 without having to stop GDB from outside at 'stop_all_threads'. I just saw that you posted a rebased version of this patch. I'll look at that, thank you. Btw, I think this patch is kind of obsolete after Pedro's comments in https://sourceware.org/ml/gdb-patches/2020-01/msg00212.html because the patch causes two stop event reports at once. -Baris -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 Gerrit-Change-Number: 133 Gerrit-PatchSet: 2 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-CC: Tom de Vries Gerrit-Comment-Date: Mon, 03 Feb 2020 16:02:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment