RE: [PATCH] gdb/testsuite: Updated includes

Lukas Durfina
2020-02-03T10:00:59Z

>
> Hello,
>
> I had assumed you pushed the patch, but in double-checking, it does not
> seem that way. Apologies for the confusion.

Hi Joel,

Sorry, I was not sure what you mean by pushing.
I assume I cannot push directly to repo, so I sent a patch.
Thanks for a hint. I am going to send an updated patch in the following email.

Best regards,
Lukas

>
> The patch is OK to wait, but can you include the ChangeLog entry in the
> revision log? It's been pretty traditional in the GDB project to have the
> revision log of the commit be the same as what's sent by email. I'll take this
> opportunity to make some suggestions on how to make the revision log a
> little more useful to those who use "git log" (I do it a lot myself). Typically, it
> looks like this:
>
> | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c
> |
> | <in most cases, a short description of the problem to better
> | understand the circumstances of the change should be provided here>
> |
> | gdb/ChangeLog:
> |
> | * gdb.base/fileio.c: Remove #include of <sys/errno.h>.
> | Replace #include of <sys/fcntl.h> by <fcntl.h>.
>
> Thank you!
>
> On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote:
> > Fixed compilation with musl.
> > ---
> > gdb/testsuite/ChangeLog | 5 +++++
> > gdb/testsuite/gdb.base/fileio.c | 3 +--
> > 2 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index
> > 3f243641b8..243721f6cb 100644
> > --- a/gdb/testsuite/ChangeLog
> > +++ b/gdb/testsuite/ChangeLog
> > @@ -1,3 +1,8 @@
> > +2020-01-09 Lukas Durfina <ldurfina@tachyum.com>
> > +
> > + * gdb.base/fileio.c: Remove #include of <sys/errno.h>.
> > + Replace #include of <sys/fcntl.h> by <fcntl.h>.
> > +
> > 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
> >
> > * gdb.base/backtrace.c: New file.
> > diff --git a/gdb/testsuite/gdb.base/fileio.c
> > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644
> > --- a/gdb/testsuite/gdb.base/fileio.c
> > +++ b/gdb/testsuite/gdb.base/fileio.c
> > @@ -1,13 +1,12 @@
> > #include <stdio.h>
> > #include <stdlib.h>
> > #include <string.h>
> > -#include <sys/errno.h>
> > #include <sys/types.h>
> > -#include <sys/fcntl.h>
> > #include <sys/stat.h>
> > #include <sys/time.h>
> > #include <errno.h>
> > #include <sys/wait.h>
> > +#include <fcntl.h>
> > #include <unistd.h>
> > #include <time.h>
> > /* TESTS :
> > --
> > 2.17.1
>
> --
> Joel