From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94117 invoked by alias); 1 Feb 2020 10:19:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94109 invoked by uid 89); 1 Feb 2020 10:19:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 01 Feb 2020 10:19:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 477C51179BB; Sat, 1 Feb 2020 05:19:45 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KDGz3riRypwZ; Sat, 1 Feb 2020 05:19:45 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CC32F11794A; Sat, 1 Feb 2020 05:19:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A116D82C47; Sat, 1 Feb 2020 14:19:40 +0400 (+04) Date: Sat, 01 Feb 2020 10:19:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Eli Zaretskii , simark@simark.ca, gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [RFA/gdb-9-branch] Abort configure immediately if building GDB in tree Message-ID: <20200201101940.GB19442@adacore.com> References: <20200105073000.1012-1-brobecker@adacore.com> <4d350c75-6e52-5c4c-5901-4c391970b643@simark.ca> <20200117181554.GB7007@adacore.com> <20200117183203.GC7007@adacore.com> <87imksmz79.fsf@redhat.com> <834kwcm63u.fsf@gnu.org> <87r1zflbft.fsf@redhat.com> <87eevfl2ze.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87eevfl2ze.fsf@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-02/txt/msg00011.txt.bz2 > >>> I'm wondering what to do here. I think I found a hacky and ugly > >>> solution here, but I'm trying to see if there's a better approach. > >> > >> A special command-line switch to 'configure', to be used by > >> src-release.sh? > > > > A quick attempt here didn't really work. The script is able to finish > > the build and create a tarball, but for some reason the gdb directory is > > not configured/built. > > OK, I think I have something that works. When 'configure' is invoked > with '--enable-src-release-build', a tarball is generated and, as far as > I have checked, contains the correct snapshot. > > WDYT? Thanks! I didn't realize that this would impact source packaging like that. Let's go with your patch. I'm about to start working on the release, so I'll apply it for you. Thanks again, > diff --git a/ChangeLog b/ChangeLog > index 0bfe989885..de13206e2e 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,11 @@ > +2020-01-31 Sergio Durigan Junior > + > + * configure.ac: Don't abort the build if trying to build GDB in tree > + _and_ invoking with '--enable-src-release-build'. > + * configure: Regenerate. > + * src-release.sh (do_proto_toplev): Invoke 'configure' using > + '--enable-src-release-build'. > + > 2020-01-17 Joel Brobecker > > * configure.ac: Abort the build with an error if trying to build > diff --git a/configure b/configure > index 7168a4e90e..276f33fee3 100755 > --- a/configure > +++ b/configure > @@ -2279,7 +2279,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu > > > > -if test x"${enable_gdb}" != x"no"; then > +if test x"${enable_gdb}" != x"no" -a x"${enable_src_release_build}" != x"yes"; then > # For this branch, we do not support building GDB in-tree. > # Try to detect whether we are in this situation or not by > # searching for a couple of known files in the source directory. > diff --git a/configure.ac b/configure.ac > index e5ca1eaa57..cd0867dd76 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -33,7 +33,7 @@ m4_include([config/isl.m4]) > AC_INIT(move-if-change) > AC_DISABLE_OPTION_CHECKING > > -if test x"${enable_gdb}" != x"no"; then > +if test x"${enable_gdb}" != x"no" -a x"${enable_src_release_build}" != x"yes"; then > # For this branch, we do not support building GDB in-tree. > # Try to detect whether we are in this situation or not by > # searching for a couple of known files in the source directory. > diff --git a/src-release.sh b/src-release.sh > index 275f0f24b5..68e824c749 100755 > --- a/src-release.sh > +++ b/src-release.sh > @@ -99,8 +99,8 @@ do_proto_toplev() > *) disables="$disables --disable-$dir" ;; > esac > done > - echo "==> configure --target=i386-pc-linux-gnu $disables $enables" > - ./configure --target=i386-pc-linux-gnu $disables $enables > + echo "==> configure --target=i386-pc-linux-gnu --enable-src-release-build=yes $disables $enables" > + ./configure --target=i386-pc-linux-gnu --enable-src-release-build=yes $disables $enables > $MAKE configure-host configure-target \ > ALL_GCC="" ALL_GCC_C="" ALL_GCC_CXX="" \ > CC_FOR_TARGET="$CC" CXX_FOR_TARGET="$CXX" -- Joel