From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110242 invoked by alias); 30 Jan 2020 16:30:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110075 invoked by uid 89); 30 Jan 2020 16:30:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Jan 2020 16:30:15 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A30AF20307; Thu, 30 Jan 2020 11:30:12 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 4435F20307; Thu, 30 Jan 2020 11:30:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 1D80A20AF7; Thu, 30 Jan 2020 11:30:07 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Thu, 30 Jan 2020 16:41:00 -0000 From: "Tankut Baris Aktemur (Code Review)" To: gdb-patches@sourceware.org Cc: Tom de Vries , Pedro Alves , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] infrun: handle already-exited threads when attempting to stop X-Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 X-Gerrit-Change-Number: 133 X-Gerrit-ChangeURL: X-Gerrit-Commit: a32b3dcee11cd3a9f40c5f07757a514074b9051f In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 30 Jan 2020 11:30:06 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200130163007.1D80A20AF7@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-01/txt/msg00972.txt.bz2 Tankut Baris Aktemur has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133 ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > FTR, I build patchset 2 and tested the example from PR25478, and hit an assert: > ... I was not able to repeat the problematic scenario with the current master. The multi-target feature seems to have changed the behavior. I'll need to first look into whether I can reproduce the infinite loop. | --- gdb/infrun.c | +++ gdb/infrun.c | @@ -4494,0 +4500,19 @@ stop_all_threads (void) | + | + /* Set the threads as non-executing to avoid infinitely | + waiting for them to stop. */ | + mark_non_executing_threads (event_ptid, ws); | + | + if (ws.kind == TARGET_WAITKIND_NO_RESUMED) | + { | + /* Do nothing. Already marked the threads. */ | + } | + if (ws.kind == TARGET_WAITKIND_THREAD_EXITED) PS2, Line 4509: Oops, yes. Thanks for spotting that. | + delete_thread (t); | + else | + { | + /* TARGET_WAITKIND_EXITED or | + TARGET_WAITKIND_SIGNALLED. */ | + /* Need to restore the context because | + handle_inferior_exit switches it. */ | + scoped_restore_current_pspace_and_thread restore; | + handle_inferior_exit (event_ptid, ws); -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 Gerrit-Change-Number: 133 Gerrit-PatchSet: 2 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-CC: Tom de Vries Gerrit-Comment-Date: Thu, 30 Jan 2020 16:30:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tom de Vries Gerrit-MessageType: comment