From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89716 invoked by alias); 30 Jan 2020 09:10:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89587 invoked by uid 89); 30 Jan 2020 09:10:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Jan 2020 09:10:57 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id AB3712032F; Thu, 30 Jan 2020 04:10:55 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 511E620178; Thu, 30 Jan 2020 04:10:53 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B82A320AF7; Thu, 30 Jan 2020 04:10:52 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Thu, 30 Jan 2020 13:58:00 -0000 From: "Tom de Vries (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: Pedro Alves , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] infrun: handle already-exited threads when attempting to stop X-Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 X-Gerrit-Change-Number: 133 X-Gerrit-ChangeURL: X-Gerrit-Commit: a32b3dcee11cd3a9f40c5f07757a514074b9051f In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 30 Jan 2020 04:10:52 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200130091052.B82A320AF7@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-01/txt/msg00968.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133 ...................................................................... Patch Set 2: (1 comment) | --- gdb/infrun.c | +++ gdb/infrun.c | @@ -4494,0 +4500,19 @@ stop_all_threads (void) | + | + /* Set the threads as non-executing to avoid infinitely | + waiting for them to stop. */ | + mark_non_executing_threads (event_ptid, ws); | + | + if (ws.kind == TARGET_WAITKIND_NO_RESUMED) | + { | + /* Do nothing. Already marked the threads. */ | + } | + if (ws.kind == TARGET_WAITKIND_THREAD_EXITED) PS2, Line 4509: This doesn't look right. Did you mean to write: else if (ws.kind == TARGET_WAITKIND_THREAD_EXITED) ? | + delete_thread (t); | + else | + { | + /* TARGET_WAITKIND_EXITED or | + TARGET_WAITKIND_SIGNALLED. */ | + /* Need to restore the context because | + handle_inferior_exit switches it. */ | + scoped_restore_current_pspace_and_thread restore; | + handle_inferior_exit (event_ptid, ws); -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408 Gerrit-Change-Number: 133 Gerrit-PatchSet: 2 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-CC: Tom de Vries Gerrit-Comment-Date: Thu, 30 Jan 2020 09:10:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment