From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4857 invoked by alias); 29 Jan 2020 14:39:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4848 invoked by uid 89); 29 Jan 2020 14:39:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Jan 2020 14:39:19 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id AC5852032B; Wed, 29 Jan 2020 09:39:17 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 9B22920256; Wed, 29 Jan 2020 09:39:16 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 4D4EE20AF7; Wed, 29 Jan 2020 09:39:16 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 29 Jan 2020 15:33:00 -0000 From: "Mihails Strasuns (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [gdb/threads] Fix hang in stop_all_threads after killing inferior X-Gerrit-Change-Id: Ibe1f29251fe2ff1c1991f041babbe18373c113b1 X-Gerrit-Change-Number: 759 X-Gerrit-ChangeURL: X-Gerrit-Commit: fe2db3d5c7f974e5387a3d2649e4c8f2d2a44bda In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 29 Jan 2020 09:39:15 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200129143916.4D4EE20AF7@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-01/txt/msg00935.txt.bz2 Mihails Strasuns has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/759 ...................................................................... Patch Set 1: This seems very similar to https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133 - I don't think there should be any logic specific to SIGKILL here. It seems like a general race condition for early termination while `stop_all_threads` is being executed. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ibe1f29251fe2ff1c1991f041babbe18373c113b1 Gerrit-Change-Number: 759 Gerrit-PatchSet: 1 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom de Vries Gerrit-CC: Mihails Strasuns Gerrit-Comment-Date: Wed, 29 Jan 2020 14:39:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment