From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37044 invoked by alias); 25 Jan 2020 00:07:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37036 invoked by uid 89); 25 Jan 2020 00:07:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 Jan 2020 00:06:59 +0000 Received: by mail-wr1-f65.google.com with SMTP id b6so4135223wrq.0 for ; Fri, 24 Jan 2020 16:06:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3kV2j6q7TUAwAW+SXBM3JDsEmmCl/1lbmwbRkM3kCBc=; b=WnIctKt2T0PliW5SCOp/DvOPmZwqHA5fhyk1AOEU1HQjGt+YZGctsfl+SGEdrIRTcr bp06OwumbGYmJHUCJq/ouNkHP0HtTVWkTGhPTx4JWLRYwOlywRtfTa5K+34rX6zUjNSc b5H2IZ9EROk+RK8l5o6XPhpzyKTdbfO/xMtqr+BdF5k0B7Stagw0tlXUMWWH+e8iPlCa Slkfcyakp6zPaHng29duGYF6JLpr6koctdaIPk4NxhQZ8JowQiijGG/UYbXldkDeTaqK 3sr8KFXkFqM2pxVlxBolgj4nDDR4tnlSSJC4DWjRLZjWdyGmGm5HeiSHjrC1DZEH+Nms D57Q== Return-Path: Received: from localhost (host86-191-239-73.range86-191.btcentralplus.com. [86.191.239.73]) by smtp.gmail.com with ESMTPSA id s16sm9680076wrn.78.2020.01.24.16.06.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Jan 2020 16:06:56 -0800 (PST) Date: Sat, 25 Jan 2020 05:08:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Improve inline frame debug experience Message-ID: <20200125000655.GA3407@embecosm.com> References: <20200106221427.GW3865@embecosm.com> <20200117165432.GB3865@embecosm.com> <875zh0ah2e.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875zh0ah2e.fsf@tromey.com> X-Fortune: Will the third world war keep "Bosom Buddies" off the air? X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00835.txt.bz2 * Tom Tromey [2020-01-24 10:40:41 -0700]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> I'd like to get this series merged as I would like to get back to > Andrew> reviewing this series: > > Andrew> https://sourceware.org/ml/gdb-patches/2019-11/msg00792.html > > Andrew> I plan to update, retest, and merge this in the next few days unless > Andrew> anyone objects. > > I found a couple of nits, but otherwise it seems ok to me; though I > don't know this area well, which is why I didn't comment until now. > > In a sub-thread, Christian pointed out an oddity which you said would be > good to handle in another patch. If that's not something you're > planning to do, would you mind filing a bug that refers to the > discussion? Thanks for taking a look at the patches. I've pushed this series now, and I'll take a look to see if I can resolve the issue Christian identified. If I can't then I'll file a bug report. Thanks, Andrew