From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11571 invoked by alias); 21 Jan 2020 12:57:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11562 invoked by uid 89); 21 Jan 2020 12:57:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Jan 2020 12:57:02 +0000 Received: by mail-wr1-f68.google.com with SMTP id y17so3074508wrh.5 for ; Tue, 21 Jan 2020 04:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LvcbAjBNzrdi7t4U/foXH7EC7Y5KzMJhYmDjV71GYa8=; b=aJd1jJNnXHMXDVIoAha+9ANA8FwfWMLAWC9KGBQiMcpC5mJreJJE0eKbq5Qqenz8RX plG9tLBsfeXtrxymHw9VlpaXE5m7qe0a+ds+WFa5pAoo+KbQ5YNnXl/apjnOZbEknkRk Kk9bSl6MXDD2DPzeLHXnXqnStiwYE4Cd8yx5NPsayCUnSOWRktpzWFdmzpN7P/OJLfRP uVYJR/6sYkysmMDQ7nHmKc6adLZOrD+7iWkS2pcbMQeueRjgEpcPLkpX6cWrPMrcJ6+y rSUYGNhOp0mJD35GulgZ9CXjEQ3jR0rkpLjepNk541FB32ZU+W2Mon1e3SQgbs5P8UC2 I0Jg== Return-Path: Received: from localhost (host86-191-239-73.range86-191.btcentralplus.com. [86.191.239.73]) by smtp.gmail.com with ESMTPSA id u84sm4033178wmg.10.2020.01.21.04.56.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Jan 2020 04:56:59 -0800 (PST) Date: Tue, 21 Jan 2020 13:01:00 -0000 From: Andrew Burgess To: Simon Marchi Cc: "Maciej W. Rozycki" , Jim Wilson , jiangshuai_li@c-sky.com, guoren@kernel.org, gdb-patches@sourceware.org, =?utf-8?B?5aSP56uL5pa5?= , yunhai_shang Subject: Re: [PATCH] riscv: add gdbserver support Message-ID: <20200121125657.GH3865@embecosm.com> References: <00e401d5cb52$63a4d000$2aee7000$@c-sky.com> <3a15e9f5-099f-3be0-e3f1-0e17c2959158@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a15e9f5-099f-3be0-e3f1-0e17c2959158@simark.ca> X-Fortune: You fill a much-needed gap. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00634.txt.bz2 * Simon Marchi [2020-01-20 20:31:31 -0500]: > On 2020-01-20 6:33 p.m., Maciej W. Rozycki wrote: > > Offhand I can see the proposal fails to implement XML register > > descriptions, which I think every modern port is expected to do (we also > > need to disallow non-XML-enabled RISC-V stubs in GDB proper, as we > > discussed before; I fail to understand why it wasn't done right away with > > the initial implementation, as it's quite straightforward and would have > > set the policy for debug stubs right from the beginning). > > I would also expect new ports to use XML target descriptions. And I see > that there is already code in arch/riscv.c to build target descriptions based > on detected features... so should gdbserver use it? Completely agree. I started reviewing this patch last weekend, but ended up getting distracted when I tried to get a RISC-V/Linux VM running again - the instructions I previously followed[1] no longer produce a usable VM. I had planned to go back and review this code next w/e, but I might hold off now to see if the xml issue is addressed. Thanks, Andrew