From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98927 invoked by alias); 19 Jan 2020 23:23:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98919 invoked by uid 89); 19 Jan 2020 23:23:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=effectively, wondered, interest X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Jan 2020 23:23:31 +0000 Received: by mail-wm1-f65.google.com with SMTP id f129so12918423wmf.2 for ; Sun, 19 Jan 2020 15:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pr0rMg+IQ2GgSu3dz1JB1gKYDUZ7Qq7zsdMpaQQulE8=; b=ekc70JtlE0Qd/mcnzX6H83E0mPTNluvhbIZue6kiZIr9i/7xDaaSeAJhvWWE8lyQlv sBB5ZM7cmm23yWscNMVGHbtf118AVz8FmIdvVFIJcITc875IjNJPVUtTIZoEk3oj2m3u bfhxQFP4QBvD7u7s9TtJj+ztFBAaysZTmWxTpr4dAyYkRCHhQeIggaxa0HK2ImR2mbOU HrVzI08bHHvYqgnupQJrDwpV5e8Y6BtG90TyOsZSU2+uYcJJmTpMRa3RauqfAum79Kkr 4n3oWuHEGjuseELw5dRaCG+UjAuGbyLw3eBdU6VFO9BWbx8u7bFHnMOdZcJRIaFxnPpJ hMyQ== Return-Path: Received: from localhost (host86-191-239-73.range86-191.btcentralplus.com. [86.191.239.73]) by smtp.gmail.com with ESMTPSA id o1sm44834660wrn.84.2020.01.19.15.23.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 19 Jan 2020 15:23:28 -0800 (PST) Date: Mon, 20 Jan 2020 00:48:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Make "disassemble" always use TUI disassembly window Message-ID: <20200119232327.GF3865@embecosm.com> References: <20191227235034.5453-1-tom@tromey.com> <20191227235034.5453-3-tom@tromey.com> <877e1n43ct.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877e1n43ct.fsf@tromey.com> X-Fortune: We are currently trying a new concept of using a live mouse. Unfortuantely, one has yet to survive being hooked up to the computer.....please bear with us. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00599.txt.bz2 * Tom Tromey [2020-01-19 13:07:30 -0700]: > >>>>> "Tom" == Tom Tromey writes: > > Tom> Currently the "disassemble" command will use the TUI disassembly > Tom> window if it is already showing. I think it makes more sense to > Tom> unconditionally switch to it. This patch implements this. > > I wonder if this should be limited to the case where the options to > disassemble are compatible with what the TUI does. I've wondered for a while if we should have something like: set tui disassemble-flags ... where a user can set the flags used by the disassembler. My main interest initially was /r, but it might be nice if /m and /s could be supported too, though I'm not quite sure how that might look or work. Anyway, if we had something like this then using a disassemble command could effectively be an alternative path to set the flags. So something like: (gdb) show tui disassemble-flags TUI will disassemble using no flags. (gdb) disassemble /r 0x..... # TUI ASM window updates, and includes opcodes. (gdb) show tui disassemble-flags TUI will disassemble using flags /r. # User doesn't want the opcodes any more, no problem. (gdb) set tui disassemble-flags # <-- passing nothing here to # clear the flags # TUI updates, but not longer shows opcodes. Just a thought. Thanks, Andrew