From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58991 invoked by alias); 5 Jan 2020 06:27:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58980 invoked by uid 89); 5 Jan 2020 06:27:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 05 Jan 2020 06:27:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0B33B117152; Sun, 5 Jan 2020 01:27:51 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ot-H7bHhWR1M; Sun, 5 Jan 2020 01:27:50 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9FDA511711B; Sun, 5 Jan 2020 01:27:50 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 51637838B8; Sun, 5 Jan 2020 10:27:46 +0400 (+04) Date: Sun, 05 Jan 2020 06:27:00 -0000 From: Joel Brobecker To: Luis Machado Cc: gdb-patches@sourceware.org, Alan.Hayward@arm.com Subject: Re: [PATCH] [AArch64] Fix erroneous use of spu architecture bfd Message-ID: <20200105062746.GC12588@adacore.com> References: <20200103191512.28770-1-luis.machado@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200103191512.28770-1-luis.machado@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-01/txt/msg00093.txt.bz2 Hi Luis, > While investigating some SVE code, i noticed the use of two spu bfd variables. > > This looks like an oversight, as the "id" field is available for non-spu > architectures as well, even though its primary use was the Cell BE > architecture. > > The following patch fixes this. > > gdb/ChangeLog: > > 2020-01-03 Luis Machado > > * aarch64-linux-nat.c > (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64 > and bfd_mach_aarch64. > > Change-Id: I817673e9a12cadfa88638870f0ff524241cf6a34 I think the patch looks pretty clear to me ;-), so you can go ahead and push. Or perhaps, before doing so: Since the Gerrit experiment is being put on hold, you might want to remove your commit hook, and then remove the "Change-Id" field above... Thanks for the patch! > --- > gdb/aarch64-linux-nat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c > index 62f5cdb1fc..4e712ebfb7 100644 > --- a/gdb/aarch64-linux-nat.c > +++ b/gdb/aarch64-linux-nat.c > @@ -970,7 +970,7 @@ aarch64_linux_nat_target::thread_architecture (ptid_t ptid) > unavailable, to distinguish from an unset value of 0. */ > struct gdbarch_info info; > gdbarch_info_init (&info); > - info.bfd_arch_info = bfd_lookup_arch (bfd_arch_spu, bfd_mach_spu); > + info.bfd_arch_info = bfd_lookup_arch (bfd_arch_aarch64, bfd_mach_aarch64); > info.id = (int *) (vq == 0 ? -1 : vq); > return gdbarch_find_by_info (info); > } > -- > 2.17.1 -- Joel