From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130963 invoked by alias); 27 Dec 2019 16:46:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130927 invoked by uid 89); 27 Dec 2019 16:46:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=folgendes, H*RU:209.85.221.66, HX-Spam-Relays-External:209.85.221.66, HX-Languages-Length:1271 X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Dec 2019 16:46:07 +0000 Received: by mail-wr1-f66.google.com with SMTP id c14so26525359wrn.7 for ; Fri, 27 Dec 2019 08:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jL6ifLIosMGLzOgKBbHBrtEQvShX70T6dWKyj2uHx7o=; b=er/AHilbbgjBwRMcqmvS3wHaDU+IsH+xk5q5tKar5XTzGqnQc7QRsqO7Lakdhezz1O 4esrZSlE8T/rUcGpQhMW4azQdeo+2I7+FRbLT/BhPUoaO8GVb3Bw30Wm836IXJLJxv3A tAis8GQ9vTw9UYFXO8FvO/QsCWnKMXH8AfGr/3EoSGfPPHcQ0vNHlMbMjS15whLtiTA6 Gt/gck/zw+Z++pycLy/fR0+iofbOFTQT6c1o+f34K/iKES50/NvE0qCVSrLm1CmjyGLw 819hSr/997PmRbLOseQV8KMrgRpVoIf59sLrCjixVHxfoE3e2oUXmojsYrUPhPnH0Vkg hA5w== Return-Path: Received: from localhost (host86-186-80-236.range86-186.btcentralplus.com. [86.186.80.236]) by smtp.gmail.com with ESMTPSA id 60sm36278470wrn.86.2019.12.27.08.46.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Dec 2019 08:46:01 -0800 (PST) Date: Fri, 27 Dec 2019 16:46:00 -0000 From: Andrew Burgess To: Hannes Domani Cc: Gdb-patches Subject: Re: [PATCH 1/3] pe_bfd_read_buildid memory leak Message-ID: <20191227164600.GN3865@embecosm.com> References: <20191224122452.1668-1-ssbssa.ref@yahoo.de> <20191224122452.1668-1-ssbssa@yahoo.de> <20191225134708.GI3865@embecosm.com> <1172377766.5695945.1577283239975@mail.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1172377766.5695945.1577283239975@mail.yahoo.com> X-Fortune: The minute a man is convinced that he is interesting, he isn't. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01039.txt.bz2 * Hannes Domani via gdb-patches [2019-12-25 14= :13:59 +0000]: > Am Mittwoch, 25. Dezember 2019, 14:47:11 MEZ hat Andrew Burgess Folgendes geschrieben: >=20 > > * Hannes Domani via gdb-patches [2019-12-2= 4 13:24:50 +0100]: > > > > > bfd/ChangeLog: > > > > > > 2019-12-24=A0 Hannes Domani=A0 > > > > > >=A0=A0=A0=A0 * peicode.h (pe_bfd_read_buildid): Free data. > > > --- > > >=A0 bfd/peicode.h | 2 ++ > > >=A0 1 file changed, 2 insertions(+) > > > > Patches for binutils-gdb/bfd/* should be posted to the binutils list > > (binutils@sourceware.org) for review. >=20 > Done. > But what about patches that change both bfd/* and gdb/*? > Send to both mailing lists? Absolutely, if they really can't be split into two parts then just post to both lists. Thanks, Andrew >=20 > > Thanks, > > Andrew > > > > > > > > > > > > diff --git a/bfd/peicode.h b/bfd/peicode.h > > > index e9d205a01a..00ccfa0a44 100644 > > > --- a/bfd/peicode.h > > > +++ b/bfd/peicode.h > > > @@ -1396,6 +1396,8 @@ pe_bfd_read_buildid (bfd *abfd) > > >=A0=A0=A0=A0=A0=A0=A0 break; > > >=A0=A0=A0=A0=A0 } > > >=A0=A0=A0=A0=A0 } > > > + > > > +=A0 free (data); > > >=A0 } > > > > > >=A0 static const bfd_target * > > > -- > > > 2.24.1 > > > >=20