From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94401 invoked by alias); 26 Dec 2019 22:17:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94389 invoked by uid 89); 26 Dec 2019 22:17:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=whitespace X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Dec 2019 22:17:09 +0000 Received: by mail-wm1-f68.google.com with SMTP id u2so6960455wmc.3 for ; Thu, 26 Dec 2019 14:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xOeLLtWJJ5tXtH3E2hJxzDAe+AGIGTyBmnVc3WyX3lY=; b=NZeJFkohh+9RsARgR7BAp6/X6+INWWxxSSgY0YUDH0reVnY+jlZVu7QBYuaKrdGBoH VZjrbZJJVtvNn3yfARuQFLMwdz9jQ6iOu9zKIrLIY99lj9czBz5G0Uo6PwhFBHYqwBv0 bluJJxU+jR3Vk9eFHpVtv5mxb2SSRPBvZtoyzpykfMVMyZyonYsny9VXcFuY0ur1o5Rf VH9KdlaX9T7CtA+PH91YCY1AtWShv5u8yRG8oYKxcncia4Jghb5aHXCMr+b7H8W7t0cG G+EkrfJDknjUatqAobagEUOnGCEYtJxlF4qVhFrlt4SuMh37KA3QK0RoiXFwJMv8t4P3 ZKpQ== Return-Path: Received: from localhost (host86-186-80-236.range86-186.btcentralplus.com. [86.186.80.236]) by smtp.gmail.com with ESMTPSA id x26sm9346731wmc.30.2019.12.26.14.17.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Dec 2019 14:17:06 -0800 (PST) Date: Thu, 26 Dec 2019 22:17:00 -0000 From: Andrew Burgess To: Bernd Edlinger Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH 2/3] gdb: Don't reorder line table entries too much when sorting. Message-ID: <20191226221705.GL3865@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: If it wasn't so warm out today, it would be cooler. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01023.txt.bz2 * Bernd Edlinger [2019-12-25 11:19:50 +0000]: > Hi, > > when I tried this patch, git am says this: > > +foreach p $patterns { > + gdb_test "step" "/\\* $p \\*/" \ > + "step to '$p'" > +} > + > -- > 2.14.5 > > Applying: gdb: Don't reorder line table entries too much when sorting. > /home/ed/gnu/binutils-gdb/.git/rebase-apply/patch:294: new blank line at EOF. > + > warning: 1 line adds whitespace errors. Thanks, I fixed two whitespace errors in this patch. > > > I just was curious to try this patch series, > since this has some overlap with a patch I posted here: > https://sourceware.org/ml/gdb-patches/2019-11/msg00792.html > > we both want to add end_sequence here: > > @@ -21330,7 +21331,8 @@ lnp_state_machine::record_line (bool end_sequence) > > else if (m_op_index == 0 || end_sequence) > > { > > fe->included_p = 1; > > - if (m_record_lines_p && (producer_is_codewarrior (m_cu) || m_is_stmt)) > > + if (m_record_lines_p > > + && (producer_is_codewarrior (m_cu) || m_is_stmt || end_sequence)) > > { > > if (m_last_subfile != m_cu->get_builder ()->get_current_subfile () > > || end_sequence) > > I was not sure, if m_is_stmt is ever false when end_sequence is true, > but considered that to be safer this way too. > Does that actually happen? Honestly, I didn't check. Like you it seemed to make more sense to leave things as they are unless I have a good reason to change them. Does how I wrote the test for this help you create a test for you patch at all? If I can help in any way I'd be happy to try. Thanks, Andrew