From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105542 invoked by alias); 25 Dec 2019 13:47:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105534 invoked by uid 89); 25 Dec 2019 13:47:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:sk:host86-, HX-Spam-Relays-External:sk:host86-, H*r:sk:host86- X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Dec 2019 13:47:12 +0000 Received: by mail-wr1-f67.google.com with SMTP id z3so21846024wru.3 for ; Wed, 25 Dec 2019 05:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+hXOx9PYKvd7wOYsLadGKBEhQhtfYsxh+yilaF/46UE=; b=KH8lMXfEKCLO43Zd2hWqMYSggQQy6fPAZj49YeMmL1tFMdMFY+abADNhYS/QbiAwqJ ZaiMhMOwvZontuL/G8csJPwiGYGZirPy6wxcCf9gbczC2gfGy5mzEF2han8PZivvC+iQ 49RfngTDJm5HPOXTecbliQaSMwtg1K7N0nj0yX4q4I8XlDaIq4/faDoENpAzt912iJgf iLrue5Wa/b8AAJxX2jQv0P/S5T1Y1vq94Uww4wT9dgAR3b+whxknQW/WBeR5CKZ3SRiP LNZRgNTpxRwHpN17pxcu+ZiPfPfbKx9aZrJ/KvY4EBmUUBYB0zN6ynNS5CUZvBb3qIqc hu/A== Return-Path: Received: from localhost (host86-186-80-236.range86-186.btcentralplus.com. [86.186.80.236]) by smtp.gmail.com with ESMTPSA id o194sm5756814wme.45.2019.12.25.05.47.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Dec 2019 05:47:09 -0800 (PST) Date: Wed, 25 Dec 2019 13:47:00 -0000 From: Andrew Burgess To: Hannes Domani Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] pe_bfd_read_buildid memory leak Message-ID: <20191225134708.GI3865@embecosm.com> References: <20191224122452.1668-1-ssbssa.ref@yahoo.de> <20191224122452.1668-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191224122452.1668-1-ssbssa@yahoo.de> X-Fortune: Nature always sides with the hidden flaw. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01004.txt.bz2 * Hannes Domani via gdb-patches [2019-12-24 13:24:50 +0100]: > bfd/ChangeLog: > > 2019-12-24 Hannes Domani > > * peicode.h (pe_bfd_read_buildid): Free data. > --- > bfd/peicode.h | 2 ++ > 1 file changed, 2 insertions(+) Patches for binutils-gdb/bfd/* should be posted to the binutils list (binutils@sourceware.org) for review. Thanks, Andrew > > diff --git a/bfd/peicode.h b/bfd/peicode.h > index e9d205a01a..00ccfa0a44 100644 > --- a/bfd/peicode.h > +++ b/bfd/peicode.h > @@ -1396,6 +1396,8 @@ pe_bfd_read_buildid (bfd *abfd) > break; > } > } > + > + free (data); > } > > static const bfd_target * > -- > 2.24.1 >