From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Subject: Re: GDB 9.0.90 available for testing
Date: Mon, 23 Dec 2019 07:43:00 -0000 [thread overview]
Message-ID: <20191223074346.GC11677@adacore.com> (raw)
In-Reply-To: <83h81w14z1.fsf@gnu.org>
> > > I've now reported the problem to Readline developers. Should I go
> > > ahead and patch our local copy, or should I wait for the Readline
> > > developers to respond?
> >
> > Looks like Chet acknowledged the patch:
> > https://lists.gnu.org/archive/html/bug-readline/2019-12/msg00003.html
>
> Yes.
>
> > Given the unusual way the readline git repository is managed, probably
> > best to patch it locally for now? (not like I have any authority
> > here...)
>
> Joel, could you please advise?
Of course! :-)
Just for clarity and completeness, I'll mention that this is more
about our handling of readline inside GDB than release management.
But I've had to deal with readline issues before, so I think I know
the process, which is basically:
- Patch locally, and submit the patch to readline;
- Keep track of the patch submission on the readline end;
when a patch is applied, if different from the one accepted
upstream, then undo our local patch, and apply the one from
upstream. This ensures the one applied upstream doesn't introduce
some issues we haven't seen during review.
Another version of the process is when the fix was already applied
upstream. In that case, no need to submit anything, since it's already
fixed. We just backport the fix from upstream into GDB's version
of readline.
--
Joel
next prev parent reply other threads:[~2019-12-23 7:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 21:47 Joel Brobecker
2019-12-11 21:56 ` Joel Brobecker
2019-12-16 17:23 ` Eli Zaretskii
2019-12-16 17:38 ` Simon Marchi
2019-12-16 17:50 ` Eli Zaretskii
2019-12-23 7:54 ` Joel Brobecker
2019-12-16 18:52 ` Christian Biesinger via gdb-patches
2019-12-16 19:18 ` Eli Zaretskii
2019-12-16 19:36 ` Pedro Alves
2019-12-16 19:57 ` Eli Zaretskii
2019-12-16 20:37 ` Christian Biesinger via gdb-patches
2019-12-16 20:38 ` Pedro Alves
2019-12-17 17:25 ` Eli Zaretskii
2019-12-18 20:19 ` Christian Biesinger via gdb-patches
2019-12-19 15:00 ` Eli Zaretskii
2019-12-19 19:17 ` Christian Biesinger via gdb-patches
2019-12-19 19:38 ` Eli Zaretskii
2019-12-23 7:43 ` Joel Brobecker [this message]
2019-12-23 17:32 ` Eli Zaretskii
2019-12-24 3:53 ` Joel Brobecker
2019-12-24 15:30 ` Eli Zaretskii
2020-01-17 20:56 ` Christian Biesinger via gdb-patches
2020-01-17 21:09 ` Eli Zaretskii
2019-12-23 8:01 ` Joel Brobecker
2019-12-23 13:56 ` Eli Zaretskii
2019-12-24 3:49 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223074346.GC11677@adacore.com \
--to=brobecker@adacore.com \
--cc=cbiesinger@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox