From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22633 invoked by alias); 20 Dec 2019 17:53:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22624 invoked by uid 89); 20 Dec 2019 17:53:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2019 17:53:13 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C133E20417; Fri, 20 Dec 2019 12:53:11 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 2065920307; Fri, 20 Dec 2019 12:53:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 02E5D2816F; Fri, 20 Dec 2019 12:53:07 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 20 Dec 2019 17:53:00 -0000 From: "Simon Marchi (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Use enum bitfield for the calling_convention attribute of a subroutine X-Gerrit-Change-Id: Ibc6b2f71e885cbc5c3c9d49734f7125acbfd1bcd X-Gerrit-Change-Number: 758 X-Gerrit-ChangeURL: X-Gerrit-Commit: 95ca25f7e2684e232f9b4948df0a9c8b9419bfc5 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 20 Dec 2019 12:53:06 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191220175307.02E5D2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00917.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/758 ...................................................................... Patch Set 1: Code-Review+2 Thanks, that LGTM. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ibc6b2f71e885cbc5c3c9d49734f7125acbfd1bcd Gerrit-Change-Number: 758 Gerrit-PatchSet: 1 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-Comment-Date: Fri, 20 Dec 2019 17:53:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment