Re: [PATCH] Consistently quote variables used with "test"

Christian Biesinger via gdb-patches
2019-12-26T07:51:27Z

On Thu, Dec 19, 2019 at 8:31 PM Christian Biesinger
<cbiesinger@google.com> wrote:
>
> On Thu, Dec 19, 2019 at 1:24 PM Tom Tromey <tom@tromey.com> wrote:
> >
> > >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
> >
> > Christian> This ensures that empty variables and variables with spaces are handled
> > Christian> correctly.
> >
> > Christian> Code was inconsistent on whether the constant string (e.g. yes/no)
> > Christian> should also be quoted; I tried to be consistent with surrounding code.
> >
> > Christian> This fixes the error Eli reported during configure with mingw (though that
> > Christian> was not fatal).
> >
> > Thanks. This is ok.
>
> Thanks, pushed.
> To ssh://sourceware.org/git/binutils-gdb.git
> 1ee7b812e7..0ad6b8ee70 HEAD -> master

I just realized I only pushed this to trunk, whereas Eli reported this
issue on the gdb 9 branch. OK to push this to the branch as well?

Christian