From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59692 invoked by alias); 15 Dec 2019 02:41:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59650 invoked by uid 89); 15 Dec 2019 02:41:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=chk, sk:__jit_d, OpenCL X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Dec 2019 02:41:13 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 4BD30201C2; Sat, 14 Dec 2019 21:41:11 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id F3B782019C; Sat, 14 Dec 2019 21:41:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id D12A220AF6; Sat, 14 Dec 2019 21:41:07 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Sun, 15 Dec 2019 02:41:00 -0000 From: "Simon Marchi (Code Review)" To: Mihails Strasuns , gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] jit: remove bp locations when unregistering jit code X-Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 X-Gerrit-Change-Number: 704 X-Gerrit-ChangeURL: X-Gerrit-Commit: 232c479ef55b074173b1547b2072916bba6904c2 In-Reply-To: References: X-Gerrit-Comment-Date: Sat, 14 Dec 2019 21:41:07 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191215024107.D12A220AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00683.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704 ...................................................................... Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > Ok, so IIUC, you are using a special OpenCL runtime that happens to use the GDB JIT interface? > > Yes. I think it uses LLVM JIT infrastructure internally which is the one responsible __jit_debug_register_code call. > > It should be quite similar with the one I have linked though. Have just noticed that I had another old local patch to enable debug info for opencl: Hmm sorry, what did you link to? > > diff --git a/gdb/testsuite/lib/opencl_hostapp.c b/gdb/testsuite/lib/opencl_hostapp.c > index 9d6ce0eacb..23da3ad1f6 100644 > --- a/gdb/testsuite/lib/opencl_hostapp.c > +++ b/gdb/testsuite/lib/opencl_hostapp.c > @@ -86,7 +86,7 @@ main () > device_extensions = (char *) malloc (len); > CHK (clGetDeviceInfo (device, CL_DEVICE_EXTENSIONS, len, device_extensions, > NULL)); > - strcpy (kernel_build_opts, "-Werror -cl-opt-disable"); > + strcpy (kernel_build_opts, "-Werror -g -cl-opt-disable"); > if (strstr (device_extensions, "cl_khr_fp64") != NULL) > strcpy (kernel_build_opts + strlen (kernel_build_opts), > " -D HAVE_cl_khr_fp64"); > > With this change you may be able to trigger a pending breakpoint on the kernel function. No chance, I still see the breakpoint not getting resolved. I suppose that this is very dependent on the opencl implemention one is using? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 Gerrit-Change-Number: 704 Gerrit-PatchSet: 2 Gerrit-Owner: Mihails Strasuns Gerrit-Reviewer: Mihails Strasuns Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-CC: Luis Machado Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Sun, 15 Dec 2019 02:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment