From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124231 invoked by alias); 13 Dec 2019 21:38:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124223 invoked by uid 89); 13 Dec 2019 21:38:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 21:38:02 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D484A20211; Fri, 13 Dec 2019 16:38:00 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id B5C9720250; Fri, 13 Dec 2019 16:37:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A037420AF6; Fri, 13 Dec 2019 16:37:59 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Fri, 13 Dec 2019 21:38:00 -0000 From: "Tom Tromey (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] testsuite, cp: increase the coverage of testing pass-by-ref arguments X-Gerrit-Change-Id: Ie8ab1f260c6ad5ee4eb34b2c1597ce24af04abb6 X-Gerrit-Change-Number: 142 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3226beeefbfa7ccdf6067a34d185decf6513b52c In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 13 Dec 2019 16:37:59 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191213213759.A037420AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00619.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/142 ...................................................................... Patch Set 2: (1 comment) Thanks for the patch. I think it needs another modification, see below. | --- gdb/testsuite/gdb.cp/pass-by-ref.exp | +++ gdb/testsuite/gdb.cp/pass-by-ref.exp | @@ -24,4 +343,18 @@ foreach state $all_combinations { | + append stmts [generate_stmts "Derived" $state] | + | + append classes [generate_container_class $state] | + append stmts [generate_stmts "Container" $state "cbv_container"] | +} | + | +# Generate the program code and compile | +set program [generate_program $classes $stmts] | +set testfolder [file dirname $testfile] | +gdb_produce_source ${srcdir}/${subdir}/$srcfile $program PS2, Line 352: I think the generated source should not be put into the source directory; nor should it be part of the patch (or checked in). Instead it can be built in test case's output directory. | + | +set options {debug c++ additional_flags=-std=c++11} | +if {[prepare_for_testing "failed to prepare" $testfile $srcfile $options]} { | return -1 | } | | -if ![runto_main] then { | +if {![runto_main]} { | + untested "failed to run to main" -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ie8ab1f260c6ad5ee4eb34b2c1597ce24af04abb6 Gerrit-Change-Number: 142 Gerrit-PatchSet: 2 Gerrit-Owner: Tankut Baris Aktemur Gerrit-Reviewer: Tankut Baris Aktemur Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Fri, 13 Dec 2019 21:37:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment