From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67736 invoked by alias); 11 Dec 2019 19:54:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67723 invoked by uid 89); 11 Dec 2019 19:54:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 19:54:10 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 2E5EB2039A; Wed, 11 Dec 2019 14:54:09 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 10B58202EB; Wed, 11 Dec 2019 14:54:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id EBABB20AF6; Wed, 11 Dec 2019 14:54:05 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Wed, 11 Dec 2019 19:54:00 -0000 From: "Pedro Alves (Code Review)" To: Luis Machado , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] Fix unused function error X-Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 X-Gerrit-Change-Number: 753 X-Gerrit-ChangeURL: X-Gerrit-Commit: 443b5cfecfae1540a2d62c4da44314afe38825ab In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 11 Dec 2019 14:54:05 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191211195405.EBABB20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00432.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/753 ...................................................................... Patch Set 5: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +16,22 @@ correctly to its respective pragma, but this doesn't seem to have an effect on | +the warning. I tried to use the pragma explicitly and got the same result. | + | +ATTRIBUTE_UNUSED works fine in this case if you put it in both functions, | +which should fix warnings for both gdb and gdbserver builds. | + | +The compiler version is gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609. | + | +This is likely the result of PR64079 in GCC, which was fixed by commit | +9e96f1e1b9731c4e1ef4fbbbf0997319973f0537. | + | +To prevent other developers from attempting to use this macro, only to get | +confused by it not working as expected, it seems better to not define this | +particular macro when the compiler is GCC. PS5, Line 28: No, remove the macro for all compilers. Eliminate it completely. There's no point in using it when we can use ATTRIBUTE_UNUSED instead. | + | +gdb/ChangeLog: | + | +2019-12-11 Luis Machado | + | + * gdbsupport/safe-strerror.c: Don't include diagnostics.h. | + (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics | + macros. | + -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 Gerrit-Change-Number: 753 Gerrit-PatchSet: 5 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-CC: Christian Biesinger Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Wed, 11 Dec 2019 19:54:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment