From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57242 invoked by alias); 11 Dec 2019 17:58:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57232 invoked by uid 89); 11 Dec 2019 17:58:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 17:58:40 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 650142039A; Wed, 11 Dec 2019 12:58:37 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 3D8FD20250; Wed, 11 Dec 2019 12:58:34 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 12D0020AF6; Wed, 11 Dec 2019 12:58:34 -0500 (EST) X-Gerrit-PatchSet: 4 Date: Wed, 11 Dec 2019 17:58:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger , Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v4] Fix unused function error X-Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 X-Gerrit-Change-Number: 753 X-Gerrit-ChangeURL: X-Gerrit-Commit: 404c42e12bfc4a84dbef99bc8ec1ea0bd55cd0b9 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 11 Dec 2019 12:58:33 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191211175834.12D0020AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00426.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/753 ...................................................................... Patch Set 4: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +1,30 @@ | +Parent: 1d61b032 (Remove more shifts for sign/zero extension) | +Author: Luis Machado | +AuthorDate: 2019-12-11 11:55:49 -0300 | +Commit: Luis Machado | +CommitDate: 2019-12-11 14:06:52 -0300 | + | +Fix unused function error | + | +Attempting to build GDB in Ubuntu 16.04.6 LTS on x86_64, I ran into warnings | +that caused the build to fail: | + | +binutils-gdb/gdb/gdbsupport/safe-strerror.c:44:1: error: ‘char* select_strerror_r(char*, char*)’ defined but not used [-Werror=unused-function] select_strerror_r (char *res, char *) | + | +The diagnostics macros seem to expand correctly to their respective pragmas, | +but it doesn't seem to have an effect on the warning. I tried to use the | +pragmas explicitly and got the same result. | + | +ATTRIBUTE_UNUSED works fine in this case, if you put it in both functions, | +which should fix warnings for both gdb and gdbserver builds. | + | +The compiler version is gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609. PS3, Line 21: I tried #1 with "-Wunused" and it doesn't work. I'm trying to find some more information on when exactly this ceased to be a problem (if at all). I take it this was fixed, since Christian didn't see this problem, neither did the buildbot after the first fix. The warnings in include/diagnostics.h tell us to use these macros guarded by known versions, like so: #if __GNUC__ >= 10 # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wformat-diag" #endif We could have a construct like the above, guarded for known-to-work compiler versions, and use ATTRIBUTE_UNUSED for the rest. | + | +gdb/ChangeLog: | + | +2019-12-11 Luis Machado | + | + * gdb/gdbsupport/safe-strerror.c: Remove diagnostics.h | + (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics | + macros. | + -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 Gerrit-Change-Number: 753 Gerrit-PatchSet: 4 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-CC: Christian Biesinger Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Wed, 11 Dec 2019 17:58:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Comment-In-Reply-To: Christian Biesinger Gerrit-MessageType: comment