From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82664 invoked by alias); 11 Dec 2019 17:17:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82139 invoked by uid 89); 11 Dec 2019 17:17:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 17:17:47 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id EB31D20172; Wed, 11 Dec 2019 12:17:45 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 1EB7520172; Wed, 11 Dec 2019 12:17:44 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id DE49A20AF6; Wed, 11 Dec 2019 12:17:43 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Wed, 11 Dec 2019 17:17:00 -0000 From: "Pedro Alves (Code Review)" To: Luis Machado , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Fix unused function error X-Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 X-Gerrit-Change-Number: 753 X-Gerrit-ChangeURL: X-Gerrit-Commit: 198971b447296fd4f56d4802cb59e2620732383c In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 11 Dec 2019 12:17:43 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191211171743.DE49A20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00422.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/753 ...................................................................... Patch Set 3: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +1,30 @@ | +Parent: 1d61b032 (Remove more shifts for sign/zero extension) | +Author: Luis Machado | +AuthorDate: 2019-12-11 11:55:49 -0300 | +Commit: Luis Machado | +CommitDate: 2019-12-11 14:06:52 -0300 | + | +Fix unused function error | + | +Attempting to build GDB in Ubuntu 16.04.6 LTS on x86_64, I ran into warnings | +that caused the build to fail: | + | +binutils-gdb/gdb/gdbsupport/safe-strerror.c:44:1: error: ‘char* select_strerror_r(char*, char*)’ defined but not used [-Werror=unused-function] select_strerror_r (char *res, char *) | + | +The diagnostics macros seem to expand correctly to their respective pragmas, | +but it doesn't seem to have an effect on the warning. I tried to use the | +pragmas explicitly and got the same result. | + | +ATTRIBUTE_UNUSED works fine in this case, if you put it in both functions, | +which should fix warnings for both gdb and gdbserver builds. | + | +The compiler version is gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609. PS3, Line 21: If this is legitimately a GCC bug, then I see two choices: #1 - adjust to DIAGNOSTIC_IGNORE_UNUSED_FUNCTION to ignore "-Wunused" instead of "-Wunused-function" for buggy gcc versions, assuming that works. #2 - switch to ATTRIBUTE_UNUSED like you have, but then we should nuke DIAGNOSTIC_IGNORE_UNUSED_FUNCTION, since it doesn't work as advertised. ATTRIBUTE_UNUSED on the function like you have seems simpler for not having to push/pop, aka not requiring global context. So I'm fine with option #2. What doesn't look good to me is working around one case but letting the bug latent for another user of DIAGNOSTIC_IGNORE_UNUSED_FUNCTION. There's no other user of DIAGNOSTIC_IGNORE_UNUSED_FUNCTION currently, AFAICS, so #2 should be trivial. | + | +gdb/ChangeLog: | + | +2019-12-11 Luis Machado | + | + * gdb/gdbsupport/safe-strerror.c: Remove diagnostics.h | + (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics | + macros. | + -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 Gerrit-Change-Number: 753 Gerrit-PatchSet: 3 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Wed, 11 Dec 2019 17:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment