From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69404 invoked by alias); 9 Dec 2019 06:29:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69390 invoked by uid 89); 9 Dec 2019 06:29:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=delicate, viewing, inclusion, UD:patch X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2019 06:29:22 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id CECE220959; Mon, 9 Dec 2019 01:29:19 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 1E36C203C1; Mon, 9 Dec 2019 01:29:17 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E77B020AF6; Mon, 9 Dec 2019 01:29:16 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Mon, 09 Dec 2019 06:29:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Tom Tromey , Joel Brobecker , Luis Machado , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: 93e55f0a031b0e677d22aaba00857de902ebe685 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 9 Dec 2019 01:29:16 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191209062916.E77B020AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00331.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ...................................................................... Patch Set 5: > Patch Set 3: > > At this stage of the discussion, I think it shows that the subject is a little bit delicate and maybe we should start viewing the resolution for the 9.x branch separately from the resolution in master, because 9.x should be imminent. > > For me, the current patch is OK for 9.x, as it seems its impact is relatively controlled. > > The ignore.patch fix, on the other hand, seems a little too risky for inclusion this late before we branch 9.x. I've filed PR25260 - "Handle decl before def more robustly" to track the ignore.patch fix ( https://sourceware.org/bugzilla/show_bug.cgi?id=25260 ). -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 Gerrit-Change-Number: 29 Gerrit-PatchSet: 5 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-Reviewer: Tom de Vries Gerrit-CC: Joel Brobecker Gerrit-Comment-Date: Mon, 09 Dec 2019 06:29:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment