From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11810 invoked by alias); 6 Dec 2019 20:22:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11796 invoked by uid 89); 6 Dec 2019 20:22:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1587 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2019 20:22:20 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 95989201E0; Fri, 6 Dec 2019 15:22:18 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 7D3942030C; Fri, 6 Dec 2019 15:22:16 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 5CDCB2816F; Fri, 6 Dec 2019 15:22:16 -0500 (EST) X-Gerrit-PatchSet: 13 Date: Fri, 06 Dec 2019 20:22:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v13] Update Gnulib to the latest git version X-Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa X-Gerrit-Change-Number: 681 X-Gerrit-ChangeURL: X-Gerrit-Commit: d1f964219c0aa4f1b5453d83760fa43099c0b918 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 6 Dec 2019 15:22:15 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191206202216.5CDCB2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00246.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/681 ...................................................................... Patch Set 13: > Patch Set 13: > > > Patch Set 10: Code-Review+2 > > > > Patchset 10 looks good to me. > > > > Note that setting MAKEOVERRIDES to empty disables all the variables passed from top-level, not just CC. I really don't know if that's an issue or not. If this causes an issue for somebody, I guess they will speak up. > > > > Since this is quite a big change, can you wait a few days before pushing this to give others a bit of time to try it? > > Do CFLAGS specified at configuration time on the top level still make it to gnulib? I assume so, but just checking. I just double-checked and yes, they do. BTW, before pushing this I'd like to update this again to whatever the then-latest gnulib is because they've added a couple more compat fixes based on my bugreports. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa Gerrit-Change-Number: 681 Gerrit-PatchSet: 13 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-CC: Pedro Alves Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Fri, 06 Dec 2019 20:22:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment