From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119099 invoked by alias); 3 Dec 2019 21:30:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119063 invoked by uid 89); 3 Dec 2019 21:30:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=1.5, ov, offer X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2019 21:30:39 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id CEF16204BF; Tue, 3 Dec 2019 16:30:37 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 91D6B20391; Tue, 3 Dec 2019 16:30:36 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 65F532816F; Tue, 3 Dec 2019 16:30:36 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 03 Dec 2019 21:30:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add scalar_storage_order support for floating point X-Gerrit-Change-Id: Ic02eb711d80ce678ef0ecf8c506a626e441b8440 X-Gerrit-Change-Number: 727 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1d39dbffdd8af2c2f49d8e313f3413c17c02e70a In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 3 Dec 2019 16:30:35 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191203213036.65F532816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00106.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/727 ...................................................................... Patch Set 1: (1 comment) | --- gdb/testsuite/gdb.base/endianity.exp | +++ gdb/testsuite/gdb.base/endianity.exp | @@ -25,16 +25,17 @@ if ![runto "endianity.c:$bp_location" ] then { | return -1 | } | | -gdb_test "print o" "= {v = 3, w = 2}" "print o before assignment" | +gdb_test "print o" "= {v = 3, w = 2, f = 23.5, cplx = 1.25 \\+ 7.25 \\* I}" \ | + "print o before assignment" | | gdb_test "print o.v = 4" "= 4" | gdb_test "print o.w = 3" "= 3" | +gdb_test "print o.f = 1.5" "= 1.5" PS1, Line 33: > Just wondering why we don't set cplx, does gdb not offer a way to set complex? I don't think there's a way. I went through the GCC node about complex types, and basically gdb doesn't implement any of it, and in fact the way gdb print complex numbers for C is not a way that GCC can read. | | # scalar_storage_order requires gcc >= 6 | if { ([test_compiler_info {gcc-[0-5]-*}] || ![test_compiler_info gcc*]) } { | setup_xfail "*-*-*" | } | gdb_test "x/x &o.v" "0x04000000" | gdb_test "x/xh &o.w" "0x0300" | | -gdb_test "print o" "= {v = 4, w = 3}" "print o after assignment" -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic02eb711d80ce678ef0ecf8c506a626e441b8440 Gerrit-Change-Number: 727 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Tue, 03 Dec 2019 21:30:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment