From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32815 invoked by alias); 3 Dec 2019 16:38:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32802 invoked by uid 89); 3 Dec 2019 16:38:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=Gcc X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2019 16:38:26 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id BB9CA2032B; Tue, 3 Dec 2019 11:38:23 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id D53792032F; Tue, 3 Dec 2019 11:38:21 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B11372816F; Tue, 3 Dec 2019 11:38:21 -0500 (EST) X-Gerrit-PatchSet: 11 Date: Tue, 03 Dec 2019 16:38:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Joel Brobecker Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v11] gdb/mi: Add -symbol-info-module-{variables,functions} X-Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe X-Gerrit-Change-Number: 268 X-Gerrit-ChangeURL: X-Gerrit-Commit: 14efa16bd50fdec41dcc0a3a0106e645ef07503a In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 3 Dec 2019 11:38:21 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191203163821.B11372816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00093.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/268 ...................................................................... Patch Set 11: Code-Review+2 > Gcc 7.3.1 is what's installed on my machine by default. If I switch to a 10.0 compiler then I can reproduce this failure. > > I've updated the patch and will get a better default version of GCC setup. > > Sorry for wasting your time with this mistake. No worries. It would not be reasonable to ask everybody to test their patches with a bunch of different compilers. Others or the CI can report the breakage if the patch builds with your gcc version, but not with an older or newer one. Anyway, it builds now, LGTM. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe Gerrit-Change-Number: 268 Gerrit-PatchSet: 11 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-CC: Joel Brobecker Gerrit-Comment-Date: Tue, 03 Dec 2019 16:38:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment