From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79600 invoked by alias); 3 Dec 2019 13:49:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79592 invoked by uid 89); 3 Dec 2019 13:49:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=inclined X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2019 13:49:51 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7D799201E8; Tue, 3 Dec 2019 08:49:48 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id A2E20201E0; Tue, 3 Dec 2019 08:49:43 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 80E382816F; Tue, 3 Dec 2019 08:49:43 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Tue, 03 Dec 2019 13:49:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Andrew Burgess , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] [ARM, sim] Fix build error and warnings X-Gerrit-Change-Id: I21db699d3b61b2de8c44053e47be4387285af28f X-Gerrit-Change-Number: 726 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3225e5889d2e0ced69a230eb423d976c8fc4a338 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 3 Dec 2019 08:49:43 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191203134943.80E382816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00091.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/726 ...................................................................... Patch Set 3: (3 comments) | --- sim/arm/wrapper.c | +++ sim/arm/wrapper.c | @@ -126,16 +126,16 @@ }; | | union maverick_acc_regs | { | long double ld; /* Acc registers are 72-bits. */ | }; | | -struct maverick_regs DSPregs[16]; | -union maverick_acc_regs DSPacc[4]; | -ARMword DSPsc; | +extern struct maverick_regs DSPregs[16]; PS1, Line 132: Ok. I think i understand now. | +extern union maverick_acc_regs DSPacc[4]; | +extern ARMword DSPsc; | | static void | init (void) | { | static int done; | | if (!done) ... | @@ -231,18 +231,18 @@ sim_resume (SIM_DESC sd ATTRIBUTE_UNUSED, | SIM_RC | sim_create_inferior (SIM_DESC sd ATTRIBUTE_UNUSED, | struct bfd * abfd, | char * const *argv, | char * const *env) | { | int argvlen = 0; | int mach; | - char **arg; | + char * const *arg; PS1, Line 239: Done | | init (); | | if (abfd != NULL) | { | ARMul_SetPC (state, bfd_get_start_address (abfd)); | mach = bfd_get_mach (abfd); | } | else ... | @@ -862,18 +862,18 @@ sim_open (SIM_OPEN_KIND kind, | CPU_REG_FETCH (cpu) = arm_reg_fetch; | CPU_REG_STORE (cpu) = arm_reg_store; | CPU_PC_FETCH (cpu) = arm_pc_get; | CPU_PC_STORE (cpu) = arm_pc_set; | } | | sim_callback = cb; | | - sim_target_parse_arg_array (argv); | + sim_target_parse_arg_array ((char **) argv); PS1, Line 870: The code lacks more documentation to make it clear what the intent was. As is, the code is already doing something it shouldn't, based on the types passed. I'm inclined to handle this in a separate patch given the main problem is a build error. | | if (argv[1] != NULL) | { | int i; | | /* Scan for memory-size switches. */ | for (i = 0; (argv[i] != NULL) && (argv[i][0] != 0); i++) | if (argv[i][0] == '-' && argv[i][1] == 'm') | { -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I21db699d3b61b2de8c44053e47be4387285af28f Gerrit-Change-Number: 726 Gerrit-PatchSet: 3 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Luis Machado Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Tue, 03 Dec 2019 13:49:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Luis Machado Comment-In-Reply-To: Andrew Burgess Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment