From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75725 invoked by alias); 2 Dec 2019 10:09:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75713 invoked by uid 89); 2 Dec 2019 10:09:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=D*ru, pru X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Dec 2019 10:09:53 +0000 Received: by mail-wr1-f66.google.com with SMTP id b18so43432969wrj.8 for ; Mon, 02 Dec 2019 02:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tuvGHaMMTTNf1ZIalkmrEi04YGtQf4fM9MmS+2XVdEI=; b=XwET9Ivjkzjb+YnmQEAKfrOW9s6B9ZRuWIRfupfLFxFdnDWS9bHoTPV6m7jRB5njze h2usXe5Zh3AIsvPjkITxJ7N8ngcDyr9n2wQx51sydw9TZ4RVyF12iXcHOHzJmpYTMYPE k18q11vGRvlW5QUi8dFgfUUTPCPrOdRR/tLRKE/ocNh2OD0G9l0OBkt/QKxvqOjbQL5S B1VbE9wWu5Cv6bpsX35QR32sjwj3OS1mn0rEWOV4KbdtLkKJuxjGPFmjCo2LtI95XRzt Mnb2WKbK76NawiBSUzKFd8sFQ9PanTVJLxmCXrlE6Pt77cgMV8K0A286p1YBqal7plzC X0rg== Return-Path: Received: from localhost (94.196.172.80.threembb.co.uk. [94.196.172.80]) by smtp.gmail.com with ESMTPSA id f24sm21855517wmb.37.2019.12.02.02.09.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Dec 2019 02:09:50 -0800 (PST) Date: Mon, 02 Dec 2019 10:09:00 -0000 From: Andrew Burgess To: "Pavel I. Kryukov" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim-utils.c: prevent buffer overflow. Message-ID: <20191202100948.GJ3410@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: There's so much to say but your eyes keep interrupting me. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00041.txt.bz2 * Pavel I. Kryukov [2019-12-01 01:53:59 +0300]: > > From 5958a57053a755030e930c63168f09ca8fab1c84 Mon Sep 17 00:00:00 2001 > From: "Pavel I. Kryukov" > Date: Sun, 1 Dec 2019 01:40:21 +0300 > Subject: [PATCH] sim-utils.c: prevent buffer overflow. > > Representation of max 32-bit integer is 10 chars. > The potential issue is observed by GCC 7 targeted to AArch64. > > sim/common/ChangeLog: > 2019-12-01 Pavel I. Kryukov > > * sim-utils.c: Prevent buffer overflow. Approved with the nit below fixed. Thanks, Andrew > --- > sim/common/ChangeLog | 4 ++++ > sim/common/sim-utils.c | 4 ++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog > index a7ec5c7..12d900e 100644 > --- a/sim/common/ChangeLog > +++ b/sim/common/ChangeLog > @@ -1,3 +1,7 @@ > +2019-12-01 Pavel I. Kryukov > + > + * sim-utils.c: Prevent buffer overflow. > + > 2019-09-23 Dimitar Dimitrov > > * gennltvals.sh: Add PRU libgloss target. > diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c > index e83a2e4..a60dd92 100644 > --- a/sim/common/sim-utils.c > +++ b/sim/common/sim-utils.c > @@ -355,7 +355,7 @@ map_to_str (unsigned map) > case io_map: return "io"; > default: > { > - static char str[10]; > + static char str[16]; > sprintf (str, "(%ld)", (long) map); I think you could/should change this call to sprintf to use xsnprintf instead. > return str; > } > @@ -385,7 +385,7 @@ access_to_str (unsigned access) > case access_read_write_exec_io: return "read_write_exec_io"; > default: > { > - static char str[10]; > + static char str[16]; > sprintf (str, "(%ld)", (long) access); Same. > return str; > }