From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75121 invoked by alias); 27 Nov 2019 22:02:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75101 invoked by uid 89); 27 Nov 2019 22:02:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 22:02:08 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 1FBF4203AC; Wed, 27 Nov 2019 17:02:07 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id DC50C201F1; Wed, 27 Nov 2019 17:02:05 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B845920AF6; Wed, 27 Nov 2019 17:02:05 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 27 Nov 2019 22:02:00 -0000 From: "Simon Marchi (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add scalar_storage_order support for floating point X-Gerrit-Change-Id: Ic02eb711d80ce678ef0ecf8c506a626e441b8440 X-Gerrit-Change-Number: 727 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1d39dbffdd8af2c2f49d8e313f3413c17c02e70a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 17:02:04 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127220205.B845920AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01072.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/727 ...................................................................... Patch Set 1: (4 comments) | --- gdb/dwarf2read.c | +++ gdb/dwarf2read.c | @@ -17681,8 +17682,19 @@ read_base_type (struct die_info *die, struct dwarf2_cu *cu) | arch = get_objfile_arch (objfile); | + enum bfd_endian byte_order = gdbarch_byte_order (arch); | + switch (endianity) | + { | + case DW_END_big: | + byte_order = BFD_ENDIAN_BIG; | + break; | + case DW_END_little: | + byte_order = BFD_ENDIAN_LITTLE; | + break; PS1, Line 17691: Not really related to this patch, since this is pre-exising code, but what do you think of complaining if `endianity` has another value than _big or _little? | + } | + | switch (encoding) | { | case DW_ATE_address: | /* Turn DW_ATE_address into a void * pointer. */ | type = init_type (objfile, TYPE_CODE_VOID, TARGET_CHAR_BIT, NULL); | type = init_pointer_type (objfile, bits, name, type); | break; | --- gdb/gdbtypes.c | +++ gdb/gdbtypes.c | @@ -2898,18 +2898,15 @@ init_boolean_type (struct objfile *objfile, | if (unsigned_p) | TYPE_UNSIGNED (t) = 1; | | return t; | } | | /* Allocate a TYPE_CODE_FLT type structure associated with OBJFILE. | BIT is the type size in bits; if BIT equals -1, the size is | determined by the floatformat. NAME is the type name. Set the | TYPE_FLOATFORMAT from FLOATFORMATS. */ PS1, Line 2907: Could you document the new parameter (especially the behavior for _UNKNOWN)? | | struct type * | init_float_type (struct objfile *objfile, | int bit, const char *name, | - const struct floatformat **floatformats) | -{ | - struct gdbarch *gdbarch = get_objfile_arch (objfile); | - const struct floatformat *fmt = floatformats[gdbarch_byte_order (gdbarch)]; | + const struct floatformat **floatformats, | --- gdb/testsuite/gdb.base/endianity.c | +++ gdb/testsuite/gdb.base/endianity.c | @@ -15,17 +15,19 @@ /* This testcase is part of GDB, the GNU debugger. | You should have received a copy of the GNU General Public License | along with this program. If not, see . */ | | /* This tests the handling of dwarf attributes: | DW_AT_endianity, DW_END_big, and DW_END_little. */ | struct otherendian | { | int v; | short w; | + float f; PS1, Line 24: I wonder if we should test double too, or if it would be superfluous? | + __complex__ float cplx; | } | #if defined __GNUC__ && (__GNUC__ >= 6) | #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ | __attribute__( ( scalar_storage_order( "big-endian" ) ) ) | #else | __attribute__( ( scalar_storage_order( "little-endian" ) ) ) | #endif | #endif | --- gdb/testsuite/gdb.base/endianity.exp | +++ gdb/testsuite/gdb.base/endianity.exp | @@ -25,16 +25,17 @@ if ![runto "endianity.c:$bp_location" ] then { | return -1 | } | | -gdb_test "print o" "= {v = 3, w = 2}" "print o before assignment" | +gdb_test "print o" "= {v = 3, w = 2, f = 23.5, cplx = 1.25 \\+ 7.25 \\* I}" \ | + "print o before assignment" | | gdb_test "print o.v = 4" "= 4" | gdb_test "print o.w = 3" "= 3" | +gdb_test "print o.f = 1.5" "= 1.5" PS1, Line 33: Just wondering why we don't set cplx, does gdb not offer a way to set complex? | | # scalar_storage_order requires gcc >= 6 | if { ([test_compiler_info {gcc-[0-5]-*}] || ![test_compiler_info gcc*]) } { | setup_xfail "*-*-*" | } | gdb_test "x/x &o.v" "0x04000000" | gdb_test "x/xh &o.w" "0x0300" | | -gdb_test "print o" "= {v = 4, w = 3}" "print o after assignment" -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic02eb711d80ce678ef0ecf8c506a626e441b8440 Gerrit-Change-Number: 727 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 22:02:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment