From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7470 invoked by alias); 27 Nov 2019 20:13:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7460 invoked by uid 89); 27 Nov 2019 20:13:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=pasted, customer, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 20:13:33 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 3E7FD2018B; Wed, 27 Nov 2019 15:13:31 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id B2C902018B; Wed, 27 Nov 2019 15:13:30 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 92E9820AF6; Wed, 27 Nov 2019 15:13:30 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 27 Nov 2019 20:13:00 -0000 From: "Kevin Buettner (Code Review)" To: gdb-patches@sourceware.org Cc: Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Avoid infinite recursion in find_pc_sect_line X-Gerrit-Change-Id: I595470be6ab5f61ca7e4e9e70c61a252c0deaeaa X-Gerrit-Change-Number: 682 X-Gerrit-ChangeURL: X-Gerrit-Commit: 23229a89912a2e567f1d1a4ebb7ecc5c12f86c0c In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 15:13:30 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127201330.92E9820AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01058.txt.bz2 Kevin Buettner has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/682 ...................................................................... Patch Set 1: > Patch Set 1: > > Out of curiosity, is the example backtrace from a code using the patched version of GDB? How did we break out of the recursion and into lookup_minimal_symbol_by_pc_section? I don't know the answers to either of these questions. The example backtrace was pasted from a very old customer bug report. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I595470be6ab5f61ca7e4e9e70c61a252c0deaeaa Gerrit-Change-Number: 682 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Buettner Gerrit-Reviewer: Kevin Buettner Gerrit-CC: Luis Machado Gerrit-Comment-Date: Wed, 27 Nov 2019 20:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment