From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29928 invoked by alias); 27 Nov 2019 18:20:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29919 invoked by uid 89); 27 Nov 2019 18:20:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 18:20:14 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 1DA7A203AC; Wed, 27 Nov 2019 13:20:13 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 3A2802018B; Wed, 27 Nov 2019 13:20:09 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0C3D120AF6; Wed, 27 Nov 2019 13:20:09 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 27 Nov 2019 18:20:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Andrew Burgess , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [ARM, sim] Fix build error and warnings X-Gerrit-Change-Id: I21db699d3b61b2de8c44053e47be4387285af28f X-Gerrit-Change-Number: 726 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2650f4cf5fdcdad48033763425070cfdcec43e7a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 13:20:08 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127182009.0C3D120AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01050.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/726 ...................................................................... Patch Set 1: (1 comment) | --- sim/arm/wrapper.c | +++ sim/arm/wrapper.c | @@ -126,16 +126,16 @@ }; | | union maverick_acc_regs | { | long double ld; /* Acc registers are 72-bits. */ | }; | | -struct maverick_regs DSPregs[16]; | -union maverick_acc_regs DSPacc[4]; | -ARMword DSPsc; | +extern struct maverick_regs DSPregs[16]; PS1, Line 132: Yeah. I'm not too familiar with this code, but it seems a bit messy. I think this is an artifact of old changes. The comment makes it sound like we may not include maverick, but Makefile.in includes it unconditionally. In this case, i think having the definition in maverick.c and having it external in wrapper.c makes more sense. | +extern union maverick_acc_regs DSPacc[4]; | +extern ARMword DSPsc; | | static void | init (void) | { | static int done; | | if (!done) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I21db699d3b61b2de8c44053e47be4387285af28f Gerrit-Change-Number: 726 Gerrit-PatchSet: 1 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Luis Machado Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 18:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Luis Machado Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment