From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-161427-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 115567 invoked by alias); 27 Nov 2019 08:22:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 115558 invoked by uid 89); 27 Nov 2019 08:22:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 08:22:52 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id A1590203AE; Wed, 27 Nov 2019 03:22:50 -0500 (EST)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca])	by mx1.osci.io (Postfix) with ESMTP id C309D20187;	Wed, 27 Nov 2019 03:22:48 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A00C320AF6;	Wed, 27 Nov 2019 03:22:48 -0500 (EST)
X-Gerrit-PatchSet: 2
Date: Wed, 27 Nov 2019 08:22:00 -0000
From: "Mihails Strasuns (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@linaro.org>,	Simon Marchi <simon.marchi@polymtl.ca>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review v2] jit: remove bp locations when unregistering jit code
X-Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1
X-Gerrit-Change-Number: 704
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704>
X-Gerrit-Commit: 232c479ef55b074173b1547b2072916bba6904c2
In-Reply-To: <gerrit.1574686491000.Id9133540d67fa0c4619ac88324b0349b89e4b2b1@gnutoolchain-gerrit.osci.io>
References: <gerrit.1574686491000.Id9133540d67fa0c4619ac88324b0349b89e4b2b1@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Wed, 27 Nov 2019 03:22:48 -0500
Reply-To: gnutoolchain-gerrit@osci.io
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3-79-g83ff7f88f1
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191127082248.A00C320AF6@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-11/txt/msg01025.txt.bz2

Mihails Strasuns has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704
......................................................................


Patch Set 2:

> That function should take care of removing said locations, no? Is something off with that particular function that is preventing GDB from updating the list of locations?

It doesn't currently remove or disable locations in any way, only clears symtab references:

~~~
void
breakpoint_free_objfile (struct objfile *objfile)
{
  struct bp_location **locp, *loc;

  ALL_BP_LOCATIONS (loc, locp)
    if (loc->symtab != NULL && SYMTAB_OBJFILE (loc->symtab) == objfile)
      loc->symtab = NULL;
}
~~~


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1
Gerrit-Change-Number: 704
Gerrit-PatchSet: 2
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-CC: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 27 Nov 2019 08:22:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment