From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46029 invoked by alias); 27 Nov 2019 04:11:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46011 invoked by uid 89); 27 Nov 2019 04:11:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2627 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 04:11:25 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 415F42030C; Tue, 26 Nov 2019 23:11:23 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id C8A3120187; Tue, 26 Nov 2019 23:11:13 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id AC97420AF6; Tue, 26 Nov 2019 23:11:13 -0500 (EST) X-Gerrit-PatchSet: 7 Date: Wed, 27 Nov 2019 04:11:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Joel Brobecker , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v7] gdb/mi: Add new commands -symbol-info-{functions,variables,types} X-Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d X-Gerrit-Change-Number: 266 X-Gerrit-ChangeURL: X-Gerrit-Commit: 93b4867c1285f4b025e2f12029ec19a7ce51c286 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 26 Nov 2019 23:11:13 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127041113.AC97420AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01018.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266 ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Sorry about my previous message, operator error. This LGTM with the nits I pointed out addressed. | --- gdb/mi/mi-symbol-cmds.c | +++ gdb/mi/mi-symbol-cmds.c | @@ -62,0 +79,19 @@ output_debug_symbol (ui_out *uiout, enum search_domain kind, | + uiout->field_string ("name", sym->print_name ()); | + | + if (kind == FUNCTIONS_DOMAIN || kind == VARIABLES_DOMAIN) | + { | + string_file tmp_stream; | + type_print (SYMBOL_TYPE (sym), "", &tmp_stream, -1); | + uiout->field_string ("type", tmp_stream.string ()); | + | + std::string str = symbol_to_info_string (sym, block, kind); | + uiout->field_string ("description", str.c_str ()); PS7, Line 88: There's an overload of field_string that takes an std::string directly. Might as well use that. | + } | +} | + | +/* Actually output one nondebug symbol, puts a tuple emitter in place | + and then outputs the fields for this msymbol. */ | + | +static void | +output_nondebug_symbol (ui_out *uiout, | + const struct bound_minimal_symbol &msymbol) ... | @@ -62,0 +155,19 @@ mi_symbol_info (enum search_domain kind, const char *regexp, | + /* Non-debug symbols are placed after. */ | + if (i < symbols.size ()) | + { | + ui_out_emit_list nondebug_symbols_list_emitter (uiout, "nondebug"); | + | + /* As long as we have nondebug symbols... */ | + for (; i < symbols.size (); i++) | + { | + gdb_assert (symbols[i].msymbol.minsym != nullptr); | + output_nondebug_symbol(uiout, symbols[i].msymbol); PS7, Line 164: Missing space here too. | + } | + } | +} | + | +/* Helper for mi_cmd_symbol_info_{functions,variables} - depending on KIND. | + Processes command line options from ARGV and ARGC. */ | + | +static void | +mi_info_functions_or_variables (enum search_domain kind, char **argv, int argc) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d Gerrit-Change-Number: 266 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-CC: Joel Brobecker Gerrit-Comment-Date: Wed, 27 Nov 2019 04:11:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment