From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48653 invoked by alias); 26 Nov 2019 23:46:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48552 invoked by uid 89); 26 Nov 2019 23:46:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=remained, stolen X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2019 23:46:31 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 93643202DF; Tue, 26 Nov 2019 18:46:07 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 6D11E202DF; Tue, 26 Nov 2019 18:46:05 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 4A8B720AF6; Tue, 26 Nov 2019 18:46:05 -0500 (EST) X-Gerrit-PatchSet: 7 Date: Tue, 26 Nov 2019 23:46:00 -0000 From: "Andrew Burgess (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Joel Brobecker , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v7] gdb/mi: Add new commands -symbol-info-{functions,variables,types} X-Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d X-Gerrit-Change-Number: 266 X-Gerrit-ChangeURL: X-Gerrit-Commit: 93b4867c1285f4b025e2f12029ec19a7ce51c286 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 26 Nov 2019 18:46:04 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191126234605.4A8B720AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00994.txt.bz2 Andrew Burgess has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266 ...................................................................... Patch Set 7: Simon, thanks for the awesome feedback. I've stolen your code to use as the core of the symbol printing loop. I've addressed the few other issues that remained in code that isn't deleted as a result of switching to your printing algorithm. I think everything raised so far is now addressed in this latest version. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic2fc6a6750bbce91cdde2344791014e5ef45642d Gerrit-Change-Number: 266 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Tom Tromey Gerrit-CC: Joel Brobecker Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Tue, 26 Nov 2019 23:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment