From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67236 invoked by alias); 25 Nov 2019 14:06:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67227 invoked by uid 89); 25 Nov 2019 14:06:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=frees X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 14:06:44 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id DD6F020373; Mon, 25 Nov 2019 09:06:42 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 406AA20249; Mon, 25 Nov 2019 09:06:36 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0FCD420AF6; Mon, 25 Nov 2019 09:06:36 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 25 Nov 2019 14:06:00 -0000 From: "Simon Marchi (Code Review)" To: Mihails Strasuns , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] jit: minor improvement to debug logging X-Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779 X-Gerrit-Change-Number: 703 X-Gerrit-ChangeURL: X-Gerrit-Commit: 257b54210af38c96fc72a155f0ca884c939d312d In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 25 Nov 2019 09:06:35 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191125140636.0FCD420AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00826.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703 ...................................................................... Patch Set 1: (1 comment) Hi Mihails, Thanks for doing this, I just noted a small comment. | --- gdb/jit.c | +++ gdb/jit.c | @@ -953,17 +953,19 @@ jit_register_code (struct gdbarch *gdbarch, | } | | /* This function unregisters JITed code and frees the corresponding | objfile. */ | | static void | jit_unregister_code (struct objfile *objfile) | { | + if (jit_debug) | + fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%p)\n", objfile); PS1, Line 962: For a reason I can't remember, we don't use %p (because it's not reliable on some platform?). Use "%s" with host_address_to_string instead. | delete objfile; | } | | /* Look up the objfile with this code entry address. */ | | static struct objfile * | jit_find_objf_with_entry_addr (CORE_ADDR entry_addr) | { | for (objfile *objf : current_program_space->objfiles ()) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779 Gerrit-Change-Number: 703 Gerrit-PatchSet: 1 Gerrit-Owner: Mihails Strasuns Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Mon, 25 Nov 2019 14:06:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment