[review] jit: remove bp locations when unregistering jit code

["Mihails Strasuns (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Mihails Strasuns has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/breakpoint.c
| +++ gdb/breakpoint.c
| @@ -3066,2 +3091,19 @@ int
| +forget_breakpoint_locations_obj (objfile *obj)
| +{
| +  struct bp_location **blp, *bl;
| +
| +  int count = 0;
| +
| +  ALL_BP_LOCATIONS (bl, blp)
| +    if (bl->symtab != NULL && SYMTAB_OBJFILE (bl->symtab) == obj)
| +      {
| +	bool ret = remove_location_from_bp (bl->owner, bl);

PS1, Line 3100:

There is also an option of reusing existing `shlib_disabled` flag here
instead - jit code is not a shared library but underlying logic should
be quite similar. I don't fully understand possible side effects of
doing so though.

| +	gdb_assert (ret);
| +	++count;
| +      }
| +
| +  return count;
| +}
| +
|  static int internal_breakpoint_number = -1;
|  

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1
Gerrit-Change-Number: 704
Gerrit-PatchSet: 1
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 12:58:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment