[review v3] Introduce thread-safe way to handle SIGSEGV

["Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/171
......................................................................


Patch Set 3:

(2 comments)

| --- gdb/cp-support.c
| +++ gdb/cp-support.c
| @@ -1474,20 +1477,20 @@ /* If true, attempt to catch crashes in the demangler and print
|     useful debugging information.  */
|  
|  static bool catch_demangler_crashes = true;
|  
|  /* Stack context and environment for demangler crash recovery.  */
|  
| -static SIGJMP_BUF gdb_demangle_jmp_buf;
| +static thread_local SIGJMP_BUF *gdb_demangle_jmp_buf;
|  
|  /* If nonzero, attempt to dump core from the signal handler.  */

PS3, Line 1485:

"If true,"

|  
| -static int gdb_demangle_attempt_core_dump = 1;
| +static std::atomic<bool> gdb_demangle_attempt_core_dump;

PS3, Line 1487:

Is there anything ever initializing this to true?

Makes me ponder about a maintenance command to force a SIGSEGV.

|  
|  /* Signal handler for gdb_demangle.  */
|  
|  static void
|  gdb_demangle_signal_handler (int signo)
|  {
|    if (gdb_demangle_attempt_core_dump)
|      {
|        if (fork () == 0)

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic832bbb033b64744e4b44f14b41db7e4168ce427
Gerrit-Change-Number: 171
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 20:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment