From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22026 invoked by alias); 22 Nov 2019 19:00:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22011 invoked by uid 89); 22 Nov 2019 19:00:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=deserves, consumer X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 19:00:36 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 56FE8203A5; Fri, 22 Nov 2019 14:00:34 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id C381E202D0; Fri, 22 Nov 2019 14:00:32 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7EEC72816F; Fri, 22 Nov 2019 14:00:29 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Fri, 22 Nov 2019 19:00:00 -0000 From: "Pedro Alves (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Introduce run_on_main_thread X-Gerrit-Change-Id: I16ef82f0564e9f8a524bdc64cb31df79a988ad9f X-Gerrit-Change-Number: 170 X-Gerrit-ChangeURL: X-Gerrit-Commit: 589c84aae29ef0c581d1a607a800f69beaaa1795 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 14:00:29 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122190029.7EEC72816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00736.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/170 ...................................................................... Patch Set 3: Actually, I have one comment more. I only realized this is declared in ser-event.h when I read a following patch. Blame it on not being used to gerrit. :-D run_on_main_thread happens to use ser-event internally, but that's an implementation detail. I'd rather not leak implementation details like this. I think it deserves its own run-on-main-thread.h/c (or some such) files. Leave it as a consumer of ser-event, not a sibling. IMO. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I16ef82f0564e9f8a524bdc64cb31df79a988ad9f Gerrit-Change-Number: 170 Gerrit-PatchSet: 3 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Pedro Alves Gerrit-Comment-Date: Fri, 22 Nov 2019 19:00:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment