From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122856 invoked by alias); 22 Nov 2019 18:39:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122834 invoked by uid 89); 22 Nov 2019 18:38:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=maint X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 18:38:58 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id E0DB1202D0; Fri, 22 Nov 2019 13:38:56 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id E420E202EB; Fri, 22 Nov 2019 13:38:55 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id D009B2816F; Fri, 22 Nov 2019 13:38:51 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Fri, 22 Nov 2019 18:39:00 -0000 From: "Pedro Alves (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Introduce run_on_main_thread X-Gerrit-Change-Id: I16ef82f0564e9f8a524bdc64cb31df79a988ad9f X-Gerrit-Change-Number: 170 X-Gerrit-ChangeURL: X-Gerrit-Commit: 589c84aae29ef0c581d1a607a800f69beaaa1795 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 13:38:49 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122183851.D009B2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00735.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/170 ...................................................................... Patch Set 3: Code-Review+2 (2 comments) | --- gdb/ser-event.c | +++ gdb/ser-event.c | @@ -220,0 +228,19 @@ /* The serial event used when posting runnables. */ | + | +static struct serial_event *runnable_event; | + | +/* Runnables that have been posted. */ | + | +static std::vector> runnables; | + | +#if CXX_STD_THREAD | + | +/* Mutex to hold when handling runnable_event or runnables. */ PS3, Line 237: Uppercase runnable_event / runnables ? | + | +static std::mutex runnable_mutex; | + | +#endif | + | +/* Run all the queued runnables. */ | + | +static void | +run_events (int error, gdb_client_data client_data) | --- /dev/null | +++ gdb/unittests/main-thread-selftests.c | @@ -1,0 +68,13 @@ run_tests () | +#endif | + | +} | +} | + | +void | +_initialize_main_thread_selftests () | +{ | +#if CXX_STD_THREAD | + selftests::register_test ("main_thread", PS3, Line 77: Any reason this isn't named "run_on_main_thread"? Just thinking about whether that would make "maint info selftests" output more obvious. I imagine that that command could have a completer and "maint info selftests run_on" would be the obvious thing to typo. Actually, this is so minor that I don't know why I'm mentioning it. Please ignore. :-D Thanks much for adding the unit test. | + selftests::main_thread_tests::run_tests); | +#endif | +} -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I16ef82f0564e9f8a524bdc64cb31df79a988ad9f Gerrit-Change-Number: 170 Gerrit-PatchSet: 3 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Pedro Alves Gerrit-Comment-Date: Fri, 22 Nov 2019 18:38:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment