From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125301 invoked by alias); 22 Nov 2019 15:22:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125288 invoked by uid 89); 22 Nov 2019 15:22:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=17157 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 15:22:54 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 65CDC2039A; Fri, 22 Nov 2019 10:22:52 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 2BAF4202EB; Fri, 22 Nov 2019 10:22:50 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id F30162816F; Fri, 22 Nov 2019 10:22:49 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Fri, 22 Nov 2019 15:22:00 -0000 From: "Pedro Alves (Code Review)" To: Luis Machado , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] [Debugging output] Make remote packet truncation length adjustable X-Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c X-Gerrit-Change-Number: 691 X-Gerrit-ChangeURL: X-Gerrit-Commit: 378187da7c40ef613f4d58a0ed960b655da68e2c In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 10:22:49 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122152249.F30162816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00702.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691 ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Thanks. This looks good. | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +23,19 @@ gdb/ChangeLog: | +2019-11-21 Luis Machado | + | + * NEWS (New Commands): Mention "set debug remote-packet-max-chars". | + * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove. | + (remote_packet_max_chars): New static global. | + (show_remote_packet_max_chars): New function. | + (remote_target::putpkt_binary): Adjust to use new | + remote-packet-max-chars option. | + (remote_target::getpkt_or_notif_sane_1): Likewise. | + (_initialize_remote): Register new remote_packet_max_chars option. PS5, Line 32: > (_initialize_remote): Register new remote_packet_max_chars option. I guess you mean to use hyphens here as well. This is actually the case that I was referring to earlier. | + | +gdb/doc/ChangeLog: | + | +2019-11-21 Luis Machado | + | + * gdb.texinfo (Debugging Output): Document set debug | + remote-packet-max-chars. | + | +Signed-off-by: Luis Machado | --- gdb/remote.c | +++ gdb/remote.c | @@ -1715,7 +1715,19 @@ static int remote_packet_max_chars = 512; | +/* Show the maximum number of characters to display for a remote packet when | + remote debugging is enabled. */ | + | +static void | +show_remote_packet_max_chars (struct ui_file *file, int from_tty, | + struct cmd_list_element *c, | + const char *value) | +{ | + fprintf_filtered (file, _("Remote packet output will be truncated at %s " | + "characters.\n"), value); PS4, Line 1724: > "Number of remote packet characters to display is %s.\n"? That looks good. | +} | + | long | remote_target::get_memory_write_packet_size () | { | return get_memory_packet_size (&memory_write_packet_config); | } | | static struct memory_packet_config memory_read_packet_config = -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c Gerrit-Change-Number: 691 Gerrit-PatchSet: 5 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Fri, 22 Nov 2019 15:22:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Luis Machado Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment