From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104503 invoked by alias); 22 Nov 2019 11:02:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104487 invoked by uid 89); 22 Nov 2019 11:02:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1019 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 11:02:07 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id F284D203C1; Fri, 22 Nov 2019 06:02:05 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id CFED220249; Fri, 22 Nov 2019 06:02:03 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A7DC92816F; Fri, 22 Nov 2019 06:02:03 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Fri, 22 Nov 2019 11:02:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Tom Tromey , Joel Brobecker , Luis Machado , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: cede0513116b126cb1ef7506cd1ff25eb86cf878 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 06:02:03 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122110203.A7DC92816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00697.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ...................................................................... Patch Set 3: > I'm currently doing a bisect to find out at what point this stopped working. That's commit d3d323915c0 "Search global block from basic_lookup_symbol_nonlocal" -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 Gerrit-Change-Number: 29 Gerrit-PatchSet: 3 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-Reviewer: Tom de Vries Gerrit-CC: Joel Brobecker Gerrit-Comment-Date: Fri, 22 Nov 2019 11:02:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment