[review] [gdb/contrib] Add -c option to words.sh script

Kevin Buettner (Code Review)
2019-11-22T03:45:44Z

Kevin Buettner has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/654
......................................................................

Patch Set 1: Code-Review-1

Two concerns...

1) The current behavior, IIUC, is that comments are extracted. Your patch changes the default behavior to extract all words. This may come as a surprise to anyone with existing scripts which use words.sh. It might make more sense to add some other switch (perhaps -a for "all") which keeps the present default behavior intact. It's not really that important to me that this be changed, but I thought I'd mention it.

2) I'd like to see a line or two documenting the new switch in the blurb at the beginning of the file.

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ifa34d435b3c41b3ff845dc07ae4b0d9f02d92a2d
Gerrit-Change-Number: 654
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Kevin Buettner <kevinb@redhat.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 03:45:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment