From: "Kevin Buettner (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review v2] Create a correctly-sized demangled names hashtable
Date: Fri, 22 Nov 2019 02:51:00 -0000 [thread overview]
Message-ID: <20191122025056.AE3372816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1574118864000.I1f074d38e1d90af58705ec852f90c84cc034cd2e@gnutoolchain-gerrit.osci.io>
Kevin Buettner has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/686
......................................................................
Patch Set 2: Code-Review+2
> Patch Set 2:
>
> (1 comment)
>
> BTW, thoughts on me pushing this even without the threading changes, so that I have fewer patches to keep track of? Shouldn't hurt anything.
I think it makes sense to push this patch ahead of the rest of the series.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I1f074d38e1d90af58705ec852f90c84cc034cd2e
Gerrit-Change-Number: 686
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Kevin Buettner <kevinb@redhat.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Fri, 22 Nov 2019 02:50:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-22 2:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 23:14 [review] " Christian Biesinger (Code Review)
2019-11-18 23:19 ` Christian Biesinger (Code Review)
2019-11-18 23:24 ` Christian Biesinger (Code Review)
2019-11-20 4:42 ` Simon Marchi (Code Review)
2019-11-20 5:33 ` [review v2] " Christian Biesinger (Code Review)
2019-11-20 5:34 ` Christian Biesinger (Code Review)
2019-11-22 2:51 ` Kevin Buettner (Code Review) [this message]
2019-11-22 17:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-22 17:44 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122025056.AE3372816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox