From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67829 invoked by alias); 22 Nov 2019 01:06:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67809 invoked by uid 89); 22 Nov 2019 01:06:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 01:06:49 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 591362039A; Thu, 21 Nov 2019 20:06:48 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 4B587201AD; Thu, 21 Nov 2019 20:06:46 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 1FB3B2816F; Thu, 21 Nov 2019 20:06:46 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Fri, 22 Nov 2019 01:06:00 -0000 From: "Simon Marchi (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Replace the MSYMBOL_*_NAME macros with member functions X-Gerrit-Change-Id: I65aa529843a9903e174ce799037e41f954a9fcee X-Gerrit-Change-Number: 688 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0ae4b7cc25d1210e4dd1da8e729ede55edb34b59 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 21 Nov 2019 20:06:45 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122010646.1FB3B2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00685.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/688 ...................................................................... Patch Set 2: Code-Review+2 Thanks, that LGTM. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I65aa529843a9903e174ce799037e41f954a9fcee Gerrit-Change-Number: 688 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Fri, 22 Nov 2019 01:06:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment