From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50849 invoked by alias); 21 Nov 2019 21:49:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50826 invoked by uid 89); 21 Nov 2019 21:49:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=liberty X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Nov 2019 21:49:54 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A6B5420300; Thu, 21 Nov 2019 16:49:52 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 0E7D02030C; Thu, 21 Nov 2019 16:49:49 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 022BC2816F; Thu, 21 Nov 2019 16:49:49 -0500 (EST) X-Gerrit-PatchSet: 4 Date: Thu, 21 Nov 2019 21:49:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v4] [Debugging output] Make remote packet truncation length adjustable X-Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c X-Gerrit-Change-Number: 691 X-Gerrit-ChangeURL: X-Gerrit-Commit: d802904ab0945b79f44ddfff31f1d3edc1ed2c84 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 21 Nov 2019 16:49:48 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191121214949.022BC2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00677.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691 ...................................................................... Patch Set 4: (1 comment) | --- gdb/remote.c | +++ gdb/remote.c | @@ -1037,19 +1037,17 @@ /* For "set remote" and "show remote". */ | static struct cmd_list_element *remote_set_cmdlist; | static struct cmd_list_element *remote_show_cmdlist; | | /* Controls whether GDB is willing to use range stepping. */ | | static bool use_range_stepping = true; | | /* The max number of chars in debug output. The rest of chars are | omitted. */ | PS4, Line 1046: I took the liberty to make this comment a bit more grammatically correct... | -#define REMOTE_DEBUG_MAX_CHAR 512 | - | /* Private data that we'll store in (struct thread_info)->priv. */ | struct remote_thread_info : public private_thread_info | { | std::string extra; | std::string name; | int core = -1; | -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c Gerrit-Change-Number: 691 Gerrit-PatchSet: 4 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Thu, 21 Nov 2019 21:49:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment