From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30265 invoked by alias); 20 Nov 2019 18:42:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30252 invoked by uid 89); 20 Nov 2019 18:42:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1510 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2019 18:42:02 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 931C520413; Wed, 20 Nov 2019 13:42:00 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 4B5EF20334; Wed, 20 Nov 2019 13:41:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2B2952816F; Wed, 20 Nov 2019 13:41:59 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 20 Nov 2019 18:42:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [Debugging output] Make remote packet truncation length adjustable X-Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c X-Gerrit-Change-Number: 691 X-Gerrit-ChangeURL: X-Gerrit-Commit: 44ea60143f96567d5183cf80145961fc0e25a343 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 20 Nov 2019 13:41:58 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191120184159.2B2952816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00628.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691 ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > I'm not too sure packet-length-limit is good. Suggestions are welcome. > > I tend to think something in the "set debug" namespace would be better, > since it's a setting related to "set debug remote". I contemplated that, but upon looking at what sorts of options were available via "set debug", they were related to producing debugging output only, not adjusting how the debugging output was produced. So i went for more locality by putting it into "set remote". To be honest, i don't think it fits in any of those two. But i'm okay with going for "set debug remote-log-length" based on feedback. > > How about "set debug remote-log-length"? > > This patch also needs a documentation change and a NEWS entry. I'll put something together. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c Gerrit-Change-Number: 691 Gerrit-PatchSet: 1 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Wed, 20 Nov 2019 18:41:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment