From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110712 invoked by alias); 20 Nov 2019 18:12:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110700 invoked by uid 89); 20 Nov 2019 18:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2019 18:12:18 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 214662041E; Wed, 20 Nov 2019 13:12:17 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id EB0A02020A; Wed, 20 Nov 2019 13:12:11 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C23772816F; Wed, 20 Nov 2019 13:12:11 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 20 Nov 2019 18:12:00 -0000 From: "Tom Tromey (Code Review)" To: Luis Machado , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [Debugging output] Make remote packet truncation length adjustable X-Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c X-Gerrit-Change-Number: 691 X-Gerrit-ChangeURL: X-Gerrit-Commit: 44ea60143f96567d5183cf80145961fc0e25a343 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 20 Nov 2019 13:12:11 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191120181211.C23772816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00627.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691 ...................................................................... Patch Set 1: > Patch Set 1: > > I'm not too sure packet-length-limit is good. Suggestions are welcome. I tend to think something in the "set debug" namespace would be better, since it's a setting related to "set debug remote". How about "set debug remote-log-length"? This patch also needs a documentation change and a NEWS entry. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c Gerrit-Change-Number: 691 Gerrit-PatchSet: 1 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Wed, 20 Nov 2019 18:12:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment