From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22330 invoked by alias); 20 Nov 2019 05:34:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22318 invoked by uid 89); 20 Nov 2019 05:34:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2019 05:34:49 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D1149203A6; Wed, 20 Nov 2019 00:34:47 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 94F4E2020A; Wed, 20 Nov 2019 00:34:46 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 875282816F; Wed, 20 Nov 2019 00:34:46 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 20 Nov 2019 05:34:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Create a correctly-sized demangled names hashtable X-Gerrit-Change-Id: I1f074d38e1d90af58705ec852f90c84cc034cd2e X-Gerrit-Change-Number: 686 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3e511c62b9d613bd625c5ca9f2af8d0bf6697717 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 20 Nov 2019 00:34:46 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191120053446.875282816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00619.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/686 ...................................................................... Patch Set 2: (1 comment) BTW, thoughts on me pushing this even without the threading changes, so that I have fewer patches to keep track of? Shouldn't hurt anything. | --- gdb/symtab.c | +++ gdb/symtab.c | @@ -771,10 +771,17 @@ create_demangled_names_hash (struct objfile_per_bfd_storage *per_bfd) | Choosing a much larger table size wastes memory, and saves only about | - 1% in symbol reading. */ | + 1% in symbol reading. However, if the minsym count is already | + initialized (e.g. because symbol name setting was deferred to | + a background thread) we can initialize the hashtable with that | + count, because we will almost certainly have at least that | + many entries. If we have a nonzero number but less than 256, | + we still stay with 256 to have some space for psymbols, etc. */ | + | + int count = std::max (per_bfd->minimal_symbol_count, 256); PS1, Line 779: Yes, +2 is for rounding. Done and added a comment for that. | | per_bfd->demangled_names_hash.reset (htab_create_alloc | - (256, hash_demangled_name_entry, eq_demangled_name_entry, | + (count, hash_demangled_name_entry, eq_demangled_name_entry, | free_demangled_name_entry, xcalloc, xfree)); | } | | /* See symtab.h */ | -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I1f074d38e1d90af58705ec852f90c84cc034cd2e Gerrit-Change-Number: 686 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 20 Nov 2019 05:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Biesinger Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment